Skip to content

Add ExplosionPower methods to LargeFireball#9601

Closed
Doc94 wants to merge 1 commit into
PaperMC:masterfrom
Doc94:feature/no-ref/more-explosion-power-methods
Closed

Add ExplosionPower methods to LargeFireball#9601
Doc94 wants to merge 1 commit into
PaperMC:masterfrom
Doc94:feature/no-ref/more-explosion-power-methods

Conversation

@Doc94
Copy link
Copy Markdown
Member

@Doc94 Doc94 commented Aug 13, 2023

This PR add the get/set method to LargeFireball to the explosion power, if not wrong the only way to get that value is if the shooter is a Ghast but this not apply to custom LargeFireball generated.

This PR starts because wanna get the radius.. in another entites are more hardcoded..

@Doc94 Doc94 requested a review from a team as a code owner August 13, 2023 16:01
@Lulu13022002
Copy link
Copy Markdown
Contributor

This is kinda redundant with getYield/setYield ?

@Doc94
Copy link
Copy Markdown
Member Author

Doc94 commented Aug 13, 2023

This is kinda redundant with getYield/setYield ?

Oh yeah... I confuse because see in another place the explosionPower, explosionPowerRadius and now like say the yield.....

XD

@Warriorrrr
Copy link
Copy Markdown
Member

Is this still needed if those methods do the same?

@kennytv kennytv closed this Aug 21, 2023
@Doc94 Doc94 deleted the feature/no-ref/more-explosion-power-methods branch January 18, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Closed

Development

Successfully merging this pull request may close these issues.

4 participants