Fix BlockRedstoneEvent for tripwire hooks#9724
Closed
Lulu13022002 wants to merge 1 commit into
Closed
Conversation
Contributor
|
Can you merge this into https://github.com/PaperMC/Paper/blob/master/patches/server/1032-Call-BlockRedstoneEvents-for-lecterns.patch, rename the title to something like "Call BlockRedstoneEvent properly" or something the likes ? Don't forget smack yourself as a co-author 🙏 |
Lulu13022002
force-pushed
the
fix/redhook
branch
3 times, most recently
from
abc78a1 to
2bec6a6
Compare
|
Tested on base and pr. Issues reproduced on base for both tripwire hooks and lecterns. Fix confirmed for both in pr |
Warriorrrr
approved these changes
Jan 19, 2024
Member
Warriorrrr
left a comment
Warriorrrr
left a comment
There was a problem hiding this comment.
This is missing identifying patch comments but rest looks good
Lulu13022002
force-pushed
the
fix/redhook
branch
2 times, most recently
from
d9bcc96 to
16124c2
Compare
Lulu13022002
force-pushed
the
fix/redhook
branch
from
16124c2 to
1411d31
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #9714
Previously the BlockRedstoneEvent was called for every update even non redstone related one and was always unpowered (15 -> 0). Now only two events at least are called (four when cancelled, i'm not 100% sure about) and the redstone current changes are properly respected.