Fix brand name always returns null#9754
Closed
LemonCaramel wants to merge 1 commit into
Closed
Conversation
Warriorrrr
reviewed
Sep 24, 2023
Member
Warriorrrr
left a comment
Warriorrrr
left a comment
There was a problem hiding this comment.
I was thinking it'd also be possible to set the brand before the instanceof & return in handleCustomPayload, but that would result in the message received event not being called for plugins, so this seems like it'd be the simplest way to solve it at least
Member
|
The proper solution would be to actually handle the new type properly instead of just trying to bodge it out |
Contributor
|
Closing this pr, since this is a hack not a fix and your change doesn't work for the same reason electronicboy's commit doesn't either. However thank you for the report, the issue is still valid. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Honestly, I don't know if it is a good way