Skip to content

ServerKickEvent discrepencies #419

@electronicboy

Description

@electronicboy

Waterfall improved the ServerKickEvent to cover more cases, (#39), this is great because it lets plugins capture certain situations easier than vs bungee, however;

Specifically, the LOST_CONNECTION cause is generic and fired should the client disconnect from the client, leading to a specific edge case which plugins do not expect: The client has disconnected from the server

I guess this opens a question of what is the best way to go for this:

  1. Move lost connection to its own event, this could technically also be configured to support the older way of ServerKickEvent capturing this

  2. Does a LOST_CONNECTION cause really fall under a server kick event? (Too generic vs server kick which imples that the player was actually kicked, not that we just closed the connection) (Or, would this fall into 1, maybe without backwards compat)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions