Skip to content

Improve the ServerKickEvent to fire when a server crashes or shuts do…#39

Closed
fuzzybot wants to merge 1 commit into
PaperMC:masterfrom
fuzzybot:improvedserverkickevent
Closed

Improve the ServerKickEvent to fire when a server crashes or shuts do…#39
fuzzybot wants to merge 1 commit into
PaperMC:masterfrom
fuzzybot:improvedserverkickevent

Conversation

@fuzzybot
Copy link
Copy Markdown
Contributor

…wn too fast, and include the Cause

@fuzzybot
Copy link
Copy Markdown
Contributor Author

SpigotMC/BungeeCord#1846

@Techcable
Copy link
Copy Markdown
Contributor

Would this break backwards compatibility somehow?

@fuzzybot
Copy link
Copy Markdown
Contributor Author

This will not break any plugins listening to ServerKickEvent as this only adds a getCause() function, and is just firing it in a couple more cases instead of kicking the user entirely from the proxy (which a plugin would not have seen before).

This will not break any plugins listening to ServerDisconnectEvent as the event will still be fired the same way and in the same instances as before.

Techcable pushed a commit that referenced this pull request Jun 29, 2016
@Techcable Techcable closed this Jun 29, 2016
@Techcable
Copy link
Copy Markdown
Contributor

Merged manually

fuzzybot added a commit that referenced this pull request Jun 30, 2016
@nathan818fr
Copy link
Copy Markdown

I just want to point out that this is the pull request that I sent to BungeeCord (SpigotMC/BungeeCord#1851).
This is a few lines of code and I don't care, but quoting my username would have been the minimum @fuzzybot :/

@jamierocks
Copy link
Copy Markdown
Contributor

I would like to apologies on behalf of the Waterfall team. I'll rewrite the patch to have you as the author.

@jamierocks
Copy link
Copy Markdown
Contributor

d2d4426

@fuzzybot
Copy link
Copy Markdown
Contributor Author

fuzzybot commented Nov 6, 2016

ah, woops. forgot to change the author header.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants