Add missing provides directives for provided services to text-serializer-gson module descriptor - #1439
Merged
kashike merged 1 commit intoJul 25, 2026
Conversation
kashike
approved these changes
Jul 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes an issue in modular environments when using the
JSONComponentSerializerdirectly (as opposed toGsonComponentSerializer) where it fails to find a service provider forJSONComponentSerializer.Providerso it falls back to the dummy impl which only throws exceptions.A similar case applies to the data component value converter, but in that situation all providers are collected so the gson one is skipped and its converters are not registered.