web: apply frontend review fixes - #95
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applies frontend review feedback for the web interface.
Auth & routing
onMount-based auth redirects with prerender-safe+page.tsload guards:/→/loginwhen no token,/login→/when a token exists. Removes theflash of the dashboard before redirect.
login/+page.svelte.API & state
fetchApi: relative URLs, drop dead headers spread, correctly mergeAuthorizationwith caller-provided headers, and fix query-string construction.tokenstate instead of directlocalStoragereads.Components & accessibility
PatchesStatsstuck on "Loading statistics…" whentotal === 0.dark:dark:bg-white/20Tailwind class.role="progressbar"+ ARIA values on the stats bar,aria-pressedon the Table/Stats toggles, and
autocompleteon the login inputs.LabeledCheckbox,SettingsPopoverGroup,PatchesTable, andtheme.svelte.ts(dead snippets/script/style blocks, unused snippet params,SSR-safety note).
Notes
getUsername()keeps its original throw-on-missing-token behavior; thedashboard guards display with a ternary.
bun run check,bun run lint, andbun run build, plus amanual end-to-end pass against a local backend (login, dashboard, stats,
logout redirects).