Patch no time interval index search - #2050
Merged
Merged
Conversation
This commit also fixes the unstructured stommel gyre example dataset to be consistent in the variable placement with FESOM2. Specifically, the pressure, U, and V fields are face registered and the vertical velocities are vertex registered.
This test verifies that a field that has no time interval (is constant in time) evaluates to the same value. Additionally, this test is a minimal reproducer for the case that the patch in the search_time_indices function is meant to resolve. The search_time_indices function is called in the `Field.eval` method, which always expects a tuple output corresponding to the time index and the time interpolation weight. Previously, when there was no time interval, the search_time_indices function only returned a single value.
VeckoTheGecko
approved these changes
Jun 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mainfor v3 changes,v4-devfor v4 changes)This PR brings in the following changes
_search_time_indexnow returns a tuple corresponding to both the time index and the time interpolation weight, even when a field has no time interval .