Refactor dataset retrieval specs#359
Merged
Merged
Conversation
j-atkins
marked this pull request as ready for review
July 21, 2026 13:55
erikvansebille
approved these changes
Jul 21, 2026
erikvansebille
left a comment
erikvansebille
left a comment
Member
There was a problem hiding this comment.
Looks good; just one question below
|
|
||
|
|
||
| @dataclass | ||
| class FetchSpec: |
Member
There was a problem hiding this comment.
Does this class need its own unit tests? Or is it tested sufficiently with the instrument tests?
Collaborator
Author
There was a problem hiding this comment.
Added an additional test for thoroughness 👍
erikvansebille
approved these changes
Jul 22, 2026
j-atkins
added a commit
that referenced
this pull request
Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a small refactoring for the migrate-v4 branch. The previous
limit_specandspacetime_buffer_sizelogic was getting messy and unclear how the two dicts should interact. I find adding aFetchSpecdataclass in base.py to be clearer and more explicit about the requirements forInstrumentclasses and clearer about what the defaults are.