Skip to content

fix(ci): release attaches files only; dev-release requires a dev-cycle version - #8

Merged
garycoding merged 1 commit into
developfrom
fix-ci-release-and-dev-gate
Jun 16, 2026
Merged

fix(ci): release attaches files only; dev-release requires a dev-cycle version#8
garycoding merged 1 commit into
developfrom
fix-ci-release-and-dev-gate

Conversation

@garycoding

Copy link
Copy Markdown
Contributor

Two CI fixes surfaced by the first v0.8.0 release.

1. release-electron.yml — directory in the asset glob (real bug)

The "Create GitHub Release" step did files=(artifacts/**/*) with globstar, which expands to the per-OS directories (artifacts/installers-macos-latest, …) as well as the files inside. gh release create rejects a directory:

read artifacts/installers-macos-latest: is a directory

…and rolls the release back, so v0.8.0 published with no installers attached (recovered by hand). Fixed by filtering to regular files:

files=()
for f in artifacts/**/*; do [[ -f "$f" ]] && files+=("$f"); done

2. dev-release-electron.yml — require a -dev version (hardening)

The dev-release builds from "whatever develop carries." When develop sits at a plain release version (as conception-space did before the 0.8.1-dev0 cycle was opened), the dev build is versioned identically to a real release — same filename, same About-box version — so you can't tell a pre-flight from the real thing. New gate fails early:

::error:: package.json version '0.8.0' has no -dev marker; the build would be
indistinguishable from a release. Open a dev cycle first: git dev-release --open

Comment updated to match (it never needed a unique counter, but it does need a -dev marker).

No app/behaviour change; version stays 0.8.1-dev0. The same two fixes will go to the handbook Electron templates in a follow-up PR.

🤖 Generated with Claude Code

…e version

release-electron.yml attached `artifacts/**/*`, whose globstar expansion
includes the per-OS artifact directories; `gh release create` rejects a
directory ("is a directory"), so the v0.8.0 release failed to attach its
installers (recovered by hand). Filter to regular files only.

dev-release-electron.yml now gates on the source-of-truth carrying a `-dev`
marker. When develop sits at a plain release version (as it did before the
0.8.1-dev0 cycle was opened), a dev build is versioned identically to a real
release and indistinguishable in the filename / About box. Fail early with
guidance to run `git dev-release --open`.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@garycoding
garycoding merged commit 4717363 into develop Jun 16, 2026
3 checks passed
@garycoding
garycoding deleted the fix-ci-release-and-dev-gate branch June 16, 2026 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant