fix(ci): release attaches files only; dev-release requires a dev-cycle version - #8
Merged
Merged
Conversation
…e version
release-electron.yml attached `artifacts/**/*`, whose globstar expansion
includes the per-OS artifact directories; `gh release create` rejects a
directory ("is a directory"), so the v0.8.0 release failed to attach its
installers (recovered by hand). Filter to regular files only.
dev-release-electron.yml now gates on the source-of-truth carrying a `-dev`
marker. When develop sits at a plain release version (as it did before the
0.8.1-dev0 cycle was opened), a dev build is versioned identically to a real
release and indistinguishable in the filename / About box. Fail early with
guidance to run `git dev-release --open`.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two CI fixes surfaced by the first
v0.8.0release.1.
release-electron.yml— directory in the asset glob (real bug)The "Create GitHub Release" step did
files=(artifacts/**/*)withglobstar, which expands to the per-OS directories (artifacts/installers-macos-latest, …) as well as the files inside.gh release createrejects a directory:…and rolls the release back, so
v0.8.0published with no installers attached (recovered by hand). Fixed by filtering to regular files:2.
dev-release-electron.yml— require a-devversion (hardening)The dev-release builds from "whatever develop carries." When
developsits at a plain release version (as conception-space did before the0.8.1-dev0cycle was opened), the dev build is versioned identically to a real release — same filename, same About-box version — so you can't tell a pre-flight from the real thing. New gate fails early:Comment updated to match (it never needed a unique counter, but it does need a
-devmarker).No app/behaviour change; version stays
0.8.1-dev0. The same two fixes will go to the handbook Electron templates in a follow-up PR.🤖 Generated with Claude Code