This repository was archived by the owner on Dec 12, 2022. It is now read-only.
Externally owned container is no longer disposed#24
Merged
Conversation
Contributor
Author
|
@Particular/container-maintainers please review and merge // cc @andreasohlund @timbussmann |
WilliamBZA
approved these changes
Sep 29, 2016
danielmarbach
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to Particular/NServiceBus#4144
Who's affected
All users providing an externally created container into the endpoint configuration.
Symptions
If the externally owned container is disposed all instances marked as
IDisposablethat are registered by NServiceBus will be double disposed which can lead to unwanted side effects and endpoints not being able to properly shut down.