Allow default serializer to be changed#3617
Conversation
|
Still [WIP]? looks like done. |
|
WIP removed @Particular/nservicebus-maintainers please review |
|
👍 Looks good to me. Should be a useful change for ASB/ASQ. |
|
So i change transports and my serialization changes? If so you are crossing the streams. |
|
Maybe we need to bite the bullet and make the serializer mandatory
|
|
I'm all for making it mandatory if we'd rather not let transports choose their own default serializer. |
|
Seems like there are some valid reasons for not making it mandatory here though. |
Not saying that's good this but that's how it works today. Note that we're just saying to hold of with this for v6, the plan is to do it in v7 |
|
After skimming through the code of PR, it looks that ASQ code handling serialization could be simplified now to the previous shape. I'll create a separate issue for that (it doesn't have to be in the v6 scope though). |
Technically I think you could hack it today by changing it in a feature that has
DependsOn("SerializationFeature")but with this change ASB/ASQ can change it inTransportDefinition.Initializeusingsettings.SetDefault<SerializerDefinition>(new JsonSerializer())which seems more resonable.