Skip to content

Allow default serializer to be changed#3617

Merged
timbussmann merged 1 commit into
developfrom
allow-default-serializer-to-be-changed
Mar 23, 2016
Merged

Allow default serializer to be changed#3617
timbussmann merged 1 commit into
developfrom
allow-default-serializer-to-be-changed

Conversation

@andreasohlund

Copy link
Copy Markdown
Member

Technically I think you could hack it today by changing it in a feature that has DependsOn("SerializationFeature") but with this change ASB/ASQ can change it in TransportDefinition.Initialize using settings.SetDefault<SerializerDefinition>(new JsonSerializer()) which seems more resonable.

@danielmarbach

Copy link
Copy Markdown
Contributor

Still [WIP]? looks like done.

@andreasohlund andreasohlund changed the title [WIP] Allow default serializer to be changed Allow default serializer to be changed Mar 22, 2016
@andreasohlund

Copy link
Copy Markdown
Member Author

WIP removed @Particular/nservicebus-maintainers please review

@bording

bording commented Mar 22, 2016

Copy link
Copy Markdown
Member

👍 Looks good to me. Should be a useful change for ASB/ASQ.

@SimonCropp

Copy link
Copy Markdown
Contributor

So i change transports and my serialization changes? If so you are crossing the streams.

@danielmarbach

danielmarbach commented Mar 22, 2016 via email

Copy link
Copy Markdown
Contributor

@bording

bording commented Mar 22, 2016

Copy link
Copy Markdown
Member

I'm all for making it mandatory if we'd rather not let transports choose their own default serializer.

@bording

bording commented Mar 22, 2016

Copy link
Copy Markdown
Member

Seems like there are some valid reasons for not making it mandatory here though.

@andreasohlund

Copy link
Copy Markdown
Member Author

So i change transports and my serialization changes? If so you are crossing the streams.

Not saying that's good this but that's how it works today.

Note that we're just saying to hold of with this for v6, the plan is to do it in v7

@timbussmann timbussmann merged commit 118e7c5 into develop Mar 23, 2016
@timbussmann timbussmann deleted the allow-default-serializer-to-be-changed branch March 23, 2016 08:37
@Scooletz

Copy link
Copy Markdown
Contributor

After skimming through the code of PR, it looks that ASQ code handling serialization could be simplified now to the previous shape. I'll create a separate issue for that (it doesn't have to be in the v6 scope though).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants