Fix edge case where InstrumentionOptions could not be a shared instance - #7914
Merged
ramonsmits merged 1 commit intoAug 26, 2026
Merged
Conversation
irinascurtu
approved these changes
Aug 20, 2026
irinascurtu
marked this pull request as ready for review
August 25, 2026 12:13
ramonsmits
force-pushed
the
fix-otel-hostingcomponents-settings-instrumentationoptions
branch
from
August 26, 2026 12:37
61da0f0 to
2f42034
Compare
ramonsmits
force-pushed
the
fix-otel-hostingcomponents-settings-instrumentationoptions
branch
from
August 26, 2026 12:41
2f42034 to
bf13d51
Compare
tmasternak
reviewed
Aug 26, 2026
| using (Assert.EnterMultipleScope()) | ||
| { | ||
| Assert.That(handlerActivity.Events, Is.Empty, "the exception should not be recorded as a span event when the endpoint opted in to exceptions as logs"); | ||
| Assert.That(receiveActivity.Events, Is.Empty, "the exception should not be recorded as a span event when the endpoint opted in to exceptions as logs"); |
Member
There was a problem hiding this comment.
we don't need to assert on the receive activity only the handler one
…ance isn't shared
ramonsmits
force-pushed
the
fix-otel-hostingcomponents-settings-instrumentationoptions
branch
from
August 26, 2026 12:46
bf13d51 to
540e351
Compare
tmasternak
approved these changes
Aug 26, 2026
ramonsmits
deleted the
fix-otel-hostingcomponents-settings-instrumentationoptions
branch
August 26, 2026 12:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously the InstrumentationOptions during initializaion COULD result in not having a singleton/shared instance. The edge case was when initialized based on ennvvars. This was applied on the resolved non shared instance.