Installer incorrectly modifies "external ravendb" audit instance causing them to no longer start

[ramonsmits]

Describe the bug

Description

When manually configuring an instance to use "external ravendb" and then upgrading that instance the installer adds settings

<add key="ServiceControl.Audit/DBPath"
     value="C:\ProgramData\Particular\ServiceControl.Audit\localhost-44744"
     />

This conflicts with external more and results in the instance to no longer start.

Expected behavior

Ability to perform an upgrade on Windows when an instance is configured to use "external ravendb".

Actual behavior

Updating an "external ravendb" instance causes the instance to no longer start.

Versions

6.5.0

Steps to reproduce

1. Add instance with older version (for example 6.4.0)
2. Modify it to use "external ravendb"
3. Upgrade to a newer version (for example 6.5.0)

Observe the instance no longer starting due to the adding of ServiceControl.Audit/DBPath.

Relevant log output

Additional Information

Workarounds

modify config and remove ServiceControl.Audit/DBPath setting

[ramonsmits]

We've reviewed this bug and added it to our backlog. It is not currently prioritized, but it may be fixed along with other future work in the repository. We will update this issue when work begins.