Reshape the persistence contracts for groups, redirects and retry batches - #5686
Merged
Conversation
rbev
approved these changes
Aug 3, 2026
johnsimons
force-pushed
the
john/raven_refactor
branch
from
August 3, 2026 06:08
7507968 to
e1d0056
Compare
johnsimons
enabled auto-merge
August 3, 2026 06:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renames and reshapes three persistence contracts, plus the RavenDB implementations and API call that follow from them. Split out of the EF Core persister stack so the RavenDB and API changes on their own and don't complicate a release.
No EF Core behaviour changes here: those stores are still stubs, updated only to the new signatures.
Changes
Failure groups.
IGroupsDataStoremembers are named for the status they read:GetUnresolvedGroupsByClassifier,GetArchivedGroupsByClassifier,GetUnresolvedGroup,GetArchivedGroup. The two by-id lookups previously differed only in which index they read, whichneither the names nor the signatures showed.
GetUnresolvedGroupreturns a single view like itsarchived twin, so neither controller picks the first item off a list.
QueryFailureGroupViewOnGroupIdis deleted, since it ran the same query asGetUnresolvedGroup, andRetryAllInGroupHandlerusesIGroupsDataStore.GetCurrentForwardingBatchmoves to the retrystore, next to the NowForwarding document it reads, and returns a
ForwardingRetryBatchdescribingthe operation rather than a
RetryBatchwhose message list the caller never reads.Message redirects.
IMessageRedirectsDataStoreexposesAddRedirect,UpdateRedirectandRemoveRedirectinstead ofSave(collection), since every caller changes one redirect at a time.GetRedirectsstill returns all of them for the API's duplicate and dependents validation. Thedocument type moves into the RavenDB project with its stored shape, id and tick based timestamp
unchanged; the shared model keeps the redirect itself, with the lookups as extension methods.
IRetryBatchesManager.GetOrCreateMessageRedirectsCollectionduplicated the store's read, so it isremoved and
RetryProcessortakesIMessageRedirectsDataStore.Retry batches.
IRetryDocumentDataStorebecomesIRetryBatchStore, withCreateBatch,AssignMessagesToBatch,GetOrphanedBatchesandGetAvailableBatchGroups. The fourGetBatchesFor*members returned no batches at all, they enumerate the messages a retry requestcovers, so they are now
ForEachUnresolvedMessageand friends, minuscutoff,groupTitleandgroupType, which no implementation used.API behaviour changes
GET api/recoverability/groups/id/{id}andGET api/archive/groups/id/{id}return 404 for anunknown group instead of an empty 204, matching
GetErrorByIdController. ServicePulse reads theseonly to label a group and currently fails on the empty 204 anyway.
vector. Still deterministic, so conditional requests keep working; clients see one cache miss
after deploy.