Classify the search engine custom checks as built-in - #5849
Merged
Conversation
PR #5840 introduced InternalCustomCheckClassification and PR #5833 added the Error/Audit Database Search Engine custom checks. Both merged independently, so the new checks were never registered and the CustomCheckTests.VerifyCustomChecks approval tests fail on master with "MISSING FROM InternalCustomCheckClassification".
dvdstelt
approved these changes
Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#5840 and #5833 merged independently, so the
Error Database Search EngineandAudit Database Search Enginecustom checks were never added toInternalCustomCheckClassification.CustomCheckTests.VerifyCustomChecksfails on master in both RavenDB persistence test projects.