-
Notifications
You must be signed in to change notification settings - Fork 26
Description
Related to #664
After unarchiving more than 50 items, the UI would indicate that there were no further archived messages even if there were. Refreshing the browser would bring the list back up.
This was related to #664. Since we were retrieving the same 50 messages as the user scrolled, unarchiving them would naturally remove all instances of those 50 messages from the list, leaving no messages remaining.
Details of change
Fixed the paging so that the correct messages are retrieved as the user scrolls. This automatically fixed the inconsistent behavior described above.
Original bug report
Feedback from @parto:
The infinite scrolling doesn't work properly when you're trying to unarchive a lot of messages. Assume you have 200 messages to unarchive. Select the first 55, scroll to top, unarchive, you only get a few more of the preloaded items and infinite scrolling fails to fetch next pages. If you unarchive the rest of the messages that are visible on the page, it shows a "There are currently no archived messages" while the Archived Messages tab above still shows the actual number of archived messages. Refreshing the page resolves the issue though.
Technical information if reporting a bug:
- ServicePulse version: v1.14.4
- ServiceControl version: v3.0.1 / 3d24e07
- Browser version: Chrome Version 69.0