Fire a single audit query per query-control change - #3104
Merged
Conversation
A single control change on the All Messages view could fire the same query up to three times: the controls watcher called the fetch after pushing the new query to the router, the route watcher fetched again in response to that push, and the controls watcher also watched the route so it re-triggered itself once more. On slow audit instances the duplicates pile up server-side and were observed running concurrently for minutes in customer RavenDB debug packages. The route is now the single source of truth: control changes only push to the router, and only a route change triggers the fetch.
mauroservienti
approved these changes
Sep 4, 2026
tmasternak
approved these changes
Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A single control change on the All Messages view could fire the same query up to three times: the controls watcher called the fetch after pushing the new query to the router, the route watcher fetched again in response to that push, and the controls watcher also watched the route so it re-triggered itself once more. On slow audit instances the duplicates pile up server-side — they were observed running concurrently for minutes in customer RavenDB debug packages.
The route is now the single source of truth: control changes only push to the router, and only a route change triggers the fetch. The new regression tests fail against the previous implementation.
Related: