Fix Gemling Frost Wall Ice Crystal life#2386
Open
xiaoyaoyang wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2385.
Description of the problem being solved:
Advanced Thaumaturgy exposes Frost Wall's additional quality stat,
ice_crystal_maximum_life_+%, but that stat was not mapped to PoB's internalIceCrystalLifemodifier. As a result, the additional Ice Crystal Life from quality was read from the skill data and then silently discarded during skill modifier merging.This maps the stat as increased Ice Crystal Life and adds a system regression test covering a 20/20 Frost Wall with Advanced Thaumaturgy allocated.
Steps taken to verify a working solution:
400% increased Ice Crystal Life, resulting in five times the unmodified value.spec/System/TestSkills_spec.lua: 61 successes, 0 failures, 0 errors.git diff --check; repository GitHub Actions will also provide the authoritative test matrix and ModCache validation after maintainer approval for this first-time fork contribution.Link to a build that showcases this PR:
https://pobb.in/CI4hChFipObn
Before screenshot:
N/A — calculation data fix. The linked build reports approximately 30,908 Ice Crystal Life in PoB despite Advanced Thaumaturgy.
After screenshot:
N/A — covered by the added system regression test.