Add Infernal Sentinel Spectre#2259
Conversation
PJacek
left a comment
PJacek
left a comment
There was a problem hiding this comment.
Instead of copying from poedb you should read CONTRIBUTING.md to learn about exporting data from game files.
Please see my comments, run the exporter and include both the script and generated changes in your PR.
| -- Flickershade | ||
| #spectre Metadata/Monsters/Maligaro/SecretDesecrateMonster | ||
| -- Infernal Sentinel | ||
| #spectre Metadata/Monsters/Guardians/GuardianFire2_ |
There was a problem hiding this comment.
Move this to -- Ribbon section
| #mods | ||
|
|
||
| #skill SpellNovaFireRibbons Nova | ||
| #flags area spell duration |
There was a problem hiding this comment.
| #flags area spell duration | |
| #flags area spell duration | |
| #baseMod skill("showAverage", true) |
We don't want to display dps because the nova gets triggered by other skills/AI
|
Sorry, didn't know its not ok to take the values from poedb. Maybe its best to delete the PR then and i resubmit a new one when i have the time to get familiar with exporting the data from the game files myself. Thanks for the feedback! |
Feel free to message me on Discord @ Yamin#5575 and we can help get you set up with the exporter and the PoB Discord channel. We have a lot more ad-hoc discussions and can help answer general questions better there. |
ppoelzl
added
enhancement
4 participants
First time adding a spectre. In reference to #1769
https://poedb.tw/us/Infernal_Sentinel#Metadata_Monsters_Guardians_GuardianFire2_
There are three types of Infernal Sentinels, depending where you find them, but they have the same specs, so i would group them together:
Metadata_Monsters_Guardians_GuardianFire2_
Metadata_Monsters_Guardians_GuardianFire2_Schism
Metadata_Monsters_Guardians_GuardianFire2_RedNewTeam
Question, there is no 'traditional' Name for SpellNovaFireRibbons skill. Do i leave it as that or change it to something like Spell Fire Nova?