Add scripts to automatically sync unique mods with their text by Wires77 · Pull Request #2662 · PathOfBuildingCommunity/PathOfBuilding

Wires77 · 2021-04-23T07:44:13Z

Running uniqueMods.lua translates unique text into an actual mod (Run when adding new uniques)
Running uniqueText.lua translates those mods back into text (Run when the GGPK is updated, updating mod text on uniques)
This updates a lot of small text changes, not all of which I'm a fan of (GGG is pretty inconsistent with capitalization, it seems), but comes as a side effect of the mod text matching
This also updates all catalyst tags where a matching mod was found, fixing Prismatic Catalyst (Resistance) should affect unique amulet Tavukai #2521 (actually, looking at it, we have a typo for Tavukai specifically, which means the mod wasn't recognized by these scripts)

Future plans are to fix typos we have currently that are out-of-sync with the GGPK, add entries to ModParser.lua to support those differences where necessary, and improve performance.

- Running uniqueMods.lua translates unique text into an actual mod (Run when adding new uniques) - Running uniqueText.lua translates those mods back into text (Run when the GGPK is updated, updating mod text on uniques) - This updates a lot of small text changes, and updates all catalyst tags where a matching mod was found

PJacek

I glanced over the changes and there seem to be a few typos in the original data. Some of them get fixed by the export but some seem to cause issues.

ppoelzl · 2021-04-23T21:14:30Z

+	local out = io.open("../Data/Uniques/"..name..".lua", "w")
+	for line in io.lines("../Data/Uniques/Special/"..name..".lua") do
+		local specName, specVal = line:match("^([%a ]+): (.+)$")
+		if not specName and line ~= "]],[[" then


It would be cleaner to read in the whole file as a Lua table, so you don't have to split by text anymore. This would also allow for simpler surrounding code.

I actually don't know if this saves anything, after looking at it. I have to parse each line of each item anyway, and the items would be all out of order if I parsed it as a table, meaning the diffs would be impossible to double-check for errors.

Wires77 · 2021-10-08T14:29:37Z

Created another branch for this next change: Wires77/PathOfBuilding@unique_autoupdater...Wires77:unique_autoupdater_improvements

~~Didn't commit it to this branch~~, since it simply makes an assumption that the item type will be in the mod name and that still isn't accurate in all cases.

Increase accuracy of unique mods

…fBuilding into unique_autoupdater

QuickStick123 · 2022-07-04T08:05:30Z

The tags it generates seem to be inaccurate in several instances like it doesn't correctly fix x mod on low life applying from fertile catalyst and physical and chaos damage tags will need to be added to properly handle noxious catalyst.

Wires77 · 2022-07-10T10:04:37Z

The tags it generates seem to be inaccurate in several instances like it doesn't correctly fix x mod on low life applying from fertile catalyst and physical and chaos damage tags will need to be added to properly handle noxious catalyst.

Can you point out some that you noticed so I can investigate them further? The new tags should be fixed by running the scripts again. I'll try to do that again soon since so much has changed since I last updated this PR

QuickStick123 · 2022-07-10T12:33:52Z

physical -> physical damage
{tags:physical}(15-25)% increased Physical Damage
{tags:physical}{variant:1}Reflects 200 to 250 Physical Damage to Attackers on Block
{tags:attack,physical}-4 Physical Damage taken from Attacks
{variant:1,5}{tags:physical}(20-30)% increased Physical Damage
{tags:physical}(12-24)% increased Physical Damage
{tags:physical}(12-24)% increased Physical Damage
{tags:physical}−(50-40) Physical Damage taken from Attacks
{tags:physical}(25-40)% increased Physical Damage
{variant:1}{tags:attack,physical}20% more Maximum Physical Attack Damage
{variant:1}{tags:attack,physical}20% less Minimum Physical Attack Damage

remove tag: https://www.pathofexile.com/trade/search/Standard/a2GOkw7ue
{variant:1,2}{tags:physical}Right ring slot: 30% reduced Reflected Physical Damage taken
{variant:3}{tags:physical}Right ring slot: 40% reduced Reflected Physical Damage taken
{variant:4}{tags:physical}Right ring slot: 80% reduced Reflected Physical Damage taken

add physical damage
{tags:resource,life,attack}0.4% of Physical Attack Damage Leeched as Life
{tags:resource,mana,attack}0.4% of Physical Attack Damage Leeched as Mana

chaos -> chaos damage
{tags:chaos,life}200% of Life Leech applies to enemies as Chaos Damage
remove life
{tags:chaos,jewellery_defense,life}+(20-25)% Chaos Resistance when on Low Life
{tags:jewellery_defense,life}You gain 100 Evasion Rating when on Low Life
remove cast attack
{variant:1}{tags:caster,attack}5% chance to gain Onslaught for 10 seconds on Kill
remove attack
{variant:1}{tags:attack}14-20% chance to gain Fortify when you Stun an Enemy with Melee Damage
add life
{tags:defences}Gain (4-6)% of Maximum Life as Extra Maximum Energy Shield

Socketed Golem Skills is unscalable so remove all
{variant:2}{tags:resource,life,defences}Socketed Golem Skills gain 20% of Maximum Life as Extra Maximum Energy Shield
{variant:2,3}{tags:attack,caster,speed}Socketed Golem Skills have 20% increased Attack and Cast Speed

Wires77 · 2022-07-10T19:28:40Z

These differences fall into several categories:

Mods that changed wording, but are effectively the same, didn't get updated in PoB and thus their text didn't get recognized as a mod. E.g. Physical Damage taken from attacks is now "...taken from Attack Hits" instead
Legacy mods whose values changed, so the old values didn't get recognized E.g. "Reflects 200 to 250 Physical Damage to Attackers on Block" is now "Reflects 240 to 300 Physical Damage to Attackers on Block"
Don't have tags in the data, either on purpose or on accident. These would have to be tested to be sure of the behavior E.g. "0.6% of Physical Damage Leeched as Life" only has a physical tag, not physical_damage, so wouldn't get affected by that catalyst
This last one is actually fixable via scripting vs. manual changes, and that's because we're ignoring the IsScalable values on Stats.dat E.g. golem mods and ring slot mods

QuickStick123 · 2022-07-10T23:08:59Z

You are correct I incorrectly assumed since attack life work physical damage scaling would also work on the leech mod but It doesn't work from my testing.

Wires77 · 2026-04-15T06:00:01Z

Superceded by #9480

Wires77 added enhancement New feature, calculation, or mod wip Unfinished and commited for discussion labels Apr 23, 2021

Remove debugging lines

be4bed6

PJacek reviewed Apr 23, 2021

View reviewed changes

Comment thread src/Data/Uniques/shield.lua

Comment thread src/Data/Uniques/body.lua

Comment thread src/Data/Uniques/body.lua Outdated

Recognizing fractured tag, fixing some typos

90320f6

ppoelzl reviewed Apr 23, 2021

View reviewed changes

Wires77 added 6 commits April 26, 2021 02:50

Addressing PR comments

b152fa1

Merge remote-tracking branch 'fork/dev' into unique_autoupdater

7fd452c

Update unique mods and fix fractured mod erasure

2325e0e

Added fishing rod uniques back, removed Royale mods

91b0786

Removing hack now that GGG fixed their typo

54dd9f9

Increase accuracy of unique mods

94e1f76

Wires77 removed the wip Unfinished and commited for discussion label Oct 8, 2021

Wires77 added 4 commits October 11, 2021 02:13

Merge pull request #11 from Wires77/unique_autoupdater_improvements

05a6d21

Increase accuracy of unique mods

feat: Remove fractured mods from uniqueDB

5ec88d9

Merge branch 'unique_autoupdater' of https://github.com/Wires77/PathO…

f564d5a

…fBuilding into unique_autoupdater

docs: Adding info for how to run the unique mods scripts

8833b63

LocalIdentity added the technical Hidden from release notes label Oct 21, 2021

Wires77 mentioned this pull request Jul 2, 2022

Fixed a variety of incorrect catalyst scaling #4467

Merged

Wires77 added 6 commits July 10, 2022 05:08

Reset uniques to updated files

10f7f37

Merge remote-tracking branch 'fork/dev' into unique_autoupdater

140ffea

Update uniques after running script

08afbef

Text clean-up

ca43c02

Re-fix a typo

c9f35e1

PyCharm missed special file

214228c

Wires77 closed this Apr 15, 2026

Conversation

Wires77 commented Apr 23, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

PJacek left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ppoelzl Apr 23, 2021

Choose a reason for hiding this comment

Uh oh!

Wires77 Apr 26, 2021

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Wires77 commented Oct 8, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

QuickStick123 commented Jul 4, 2022

Uh oh!

Wires77 commented Jul 10, 2022

Uh oh!

QuickStick123 commented Jul 10, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Wires77 commented Jul 10, 2022

Uh oh!

QuickStick123 commented Jul 10, 2022

Uh oh!

Wires77 commented Apr 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Wires77 commented Apr 23, 2021 •

edited

Loading

Wires77 commented Oct 8, 2021 •

edited

Loading

QuickStick123 commented Jul 10, 2022 •

edited

Loading

Wires77 commented Apr 15, 2026 •

edited

Loading