Added more new gems#3001
Conversation
PJacek
left a comment
PJacek
left a comment
There was a problem hiding this comment.
Shield Crush is missing skill parts to specify if it hits with 1 or 2 waves.
Make sure you re-export after you're done with copying your changes to txt files. There are diffs and a missing quotation mark.
There is no point in adding elemental flags (lightning, fire etc.) to a skill. They don't do anything and KeywordFlags are derived from SkillType flags.
You shouldn't edit stat description files. They are purely auto-generated and your edits will be gone the next time someone uses the exporter. They are only used for displaying gem tooltips so it's not a big priority. If the description is missing it means that either GGG has messed up or our exporter is failing.
| mod("BounceCount", "BASE", nil, 0, 0 ), | ||
| }, | ||
| }, | ||
| #baseMod flag("NoAdditionalProjectiles) |
There was a problem hiding this comment.
Missing quotation mark
| #baseMod flag("NoAdditionalProjectiles) | |
| #baseMod flag("NoAdditionalProjectiles") |
There was a problem hiding this comment.
Yup, that's why I stopped using the exporter and missed the quote. I guess I'll just give up on the skill description for Concoction then.
| { | ||
| name = "Ruby", | ||
| }, | ||
| { | ||
| name = "Sapphire + Topaz", | ||
| }, | ||
| { | ||
| name = "Sapphire + Ruby", | ||
| }, | ||
| { | ||
| name = "Topaz + Ruby", | ||
| }, | ||
| { | ||
| name = "All Flasks", | ||
| }, |
Add overlapping wave Move alternate quality parsing to skillstatmap
|
Still need to fix the stat description exporter so this doesn't get overwritten. Would rather people have correct tooltips in the meantime so I'll keep it in |
* Defiance Banner Voltaxic Burst Rage Vortex Spectral Helix Battlemage's Cry - Partial Support * Earthbreaker No support for global aeo buff as it doesn't work with totems atm. Need to find fix * Absolution * Manabond * Blade Trap * Summon Reaper * Added more new gems (#3001) * shield crush * explosive concoction * spectral helix * Fix shield crush Add overlapping wave Move alternate quality parsing to skillstatmap * Clean up Spectral Helix * Clean up Explosive Concoction * Remove tags * Remove tags Co-authored-by: LocalIdentity <localidentity2@gmail.com> * Remove unnecessary flags and spaces * Storm Rain * More flags * Focused Ballista - Partial Does not implement the attack speed based off of main skill * Behead * Boneshatter * Eye of Winter * Helmet Enchant Support Also adds support for Void Sphere, Hydrosphere and Earthquake enchants * Battlemage Cry radius * style * style * Add beam overlap box to Storm Rain * style * style * style * style * style * style * style * style * style * style * style * style * style * style * Style Co-authored-by: LocalIdentity <localidentity2@gmail.com> Co-authored-by: Voronoff <davidrallen1@gmail.com> Co-authored-by: Peter Pölzl <33464174+ppoelzl@users.noreply.github.com>
3 participants
Shield Crush
Explosive Concoction
Spectral Helix
Note: Explosive Concoction involved directly editing the src/Data/StatDescriptions/skill_stat_descriptions.lua because I couldn't figure out where to put changes in order for that to generate into that file during an export. You might want to put them in the right place before accepting the pull if that isn't future proof.
Credit me as tcid please.