Fix exposure not applying from Corrosive Elements notable#3148
Conversation
PJacek
left a comment
There was a problem hiding this comment.
This technically fixes the issue but results in worse functionality than original. Now you can only view the config option and apply exposure if the main skill has the Fire, Cold or Lightning tags. There were no such restrictions before. That's because this bug was caused by you removing these lines:
dfe6984#diff-570218d1fe57724953e86ba16e300d2d6c5c7b94e23ca44b04f61a491faf2a6dL2261-L2263
They were there specifically to bypass the generic parser and stop it from applying the skill type tags. This little hack allowed for free control of exposures from config independently of the currently selected skill.
|
Bleh, you're right. Seems hacky that we have to do it that way, but we don't have the config options look at skills globally, so I'll just re-add those lines back for now. |
ppoelzl
left a comment
There was a problem hiding this comment.
LGTM, although we should come up with a better solution than sprinkling in checks for the main skill everywhere.
From: https://discord.com/channels/645607528297922560/680796887259021342/875478517486321694 and https://discord.com/channels/645607528297922560/680796887259021342/871321272167067688
Sample build to test with: