Fix enable skill tooltip visibility for non-vaal active skill gems#4606
Merged
LocalIdentity merged 1 commit intoPathOfBuildingCommunity:devfrom Jul 17, 2022
Merged
Conversation
LocalIdentity
approved these changes
Jul 17, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a bug introduced by #4493 where the toggle state of
enableGlobal1andenableGlobal2were linked to the overall skill enable state for non-vaal skill gems, causing theEnabling this gem will give youtooltip text to never be visible.Note that you will need to toggle the skills enable state if loading an old build where these variables were previously linked, as it doesn't go out of its way to correct existing data (as it technically doesn't cause any issues with the actual build, it only affects this one tooltip).
Link to a build that showcases this PR:
https://pobb.in/28v14DODnY7L
Before screenshot:
After screenshot: