Removes parsing off an unimplemented line#4732
Merged
Wires77 merged 1 commit intoPathOfBuildingCommunity:devfrom Aug 11, 2022
Merged
Removes parsing off an unimplemented line#4732Wires77 merged 1 commit intoPathOfBuildingCommunity:devfrom
Wires77 merged 1 commit intoPathOfBuildingCommunity:devfrom
Conversation
Wires77
approved these changes
Aug 11, 2022
Member
Wires77
left a comment
Wires77
left a comment
There was a problem hiding this comment.
Yeah, this was misleading. Would love to see it implemented, but this is still a good change until then.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ideally Tawhoa in Chieftain would be properly implemented, but I'd rather it be unparsed than parsed and adding a skill that does nothing.