Skip to content

Remove overkill damage and fix some bugs in eHP#4915

Merged
Wires77 merged 12 commits intoPathOfBuildingCommunity:devfrom
QuickStick123:ehp-improvements
Dec 9, 2022
Merged

Remove overkill damage and fix some bugs in eHP#4915
Wires77 merged 12 commits intoPathOfBuildingCommunity:devfrom
QuickStick123:ehp-improvements

Conversation

@QuickStick123
Copy link
Contributor

@QuickStick123 QuickStick123 commented Aug 19, 2022

Fixes: #4992 #5161 #5178
For reference: #4993

Description of the problem being solved:

eHP has breakpoints. This means when you have very low hits to death eHP won't change on moderate increases in health or damage reduction e.g. 20%.

This also refactors how infinite eHP is determined and when to stop. This is done by checking the current damage mitigated and if over a threshold declare infinite hits. Stopping is now determined if passing over a threshold of maximum number of iterations (number of times running the damage mitigation passes).

Guard skills were causing weird breakpointing behaviour due to iteration multiplier causing effective differences between speedup iterations and iteration multiplier iterations. This removes this from guard skill as the logic behind it doesn't make sense and causes undesirable behaviour.

This also includes a fix suggested by Regisle to fix recovery not being applied in future cycles leading to inefficient calculations on infinite hp recovery builds.

Steps taken to verify a working solution:

You now have partial hits before death.

Link to a build that showcases this PR:

https://pobb.in/vHR-vtTGMMrQ
https://pobb.in/5_CR0d50ihde
https://pobb.in/oFHTWXt9FMua
https://poe.ninja/pob/Kqz

Before screenshot:

image
image
image
image

After screenshot:

image
image
image
image

@QuickStick123 QuickStick123 added the enhancement New feature, calculation, or mod label Aug 19, 2022
@QuickStick123 QuickStick123 mentioned this pull request Aug 26, 2022
2 tasks
@QuickStick123 QuickStick123 changed the title Don't include overkill damage in eHP Don't include overkill damage in eHP and fix some other effective health bugs. Aug 27, 2022
@QuickStick123 QuickStick123 changed the title Don't include overkill damage in eHP and fix some other effective health bugs. Remove overkill damage and fix some bugs in eHP. Aug 27, 2022
@QuickStick123 QuickStick123 changed the title Remove overkill damage and fix some bugs in eHP. Remove overkill damage and fix some bugs in eHP Aug 27, 2022
@QuickStick123 QuickStick123 force-pushed the ehp-improvements branch 4 times, most recently from 45fcc75 to 79a4c73 Compare August 29, 2022 14:05
@QuickStick123 QuickStick123 added the bug Something isn't working label Nov 27, 2022
@QuickStick123 QuickStick123 added bug: calculation Numerical differences and removed bug Something isn't working labels Nov 28, 2022
Copy link
Member

@Wires77 Wires77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice to have a fix for these

@Wires77 Wires77 merged commit e18bedd into PathOfBuildingCommunity:dev Dec 9, 2022
@QuickStick123 QuickStick123 deleted the ehp-improvements branch December 14, 2022 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug: calculation Numerical differences enhancement New feature, calculation, or mod

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Flask effect Breakpoint?

2 participants