Fix arcanist brand giving brand skill flag to gems breaking stuff.#4966
Merged
LocalIdentity merged 1 commit intoPathOfBuildingCommunity:devfrom Dec 8, 2022
Merged
Conversation
QuickStick123
added
bug
LocalIdentity
approved these changes
Dec 8, 2022
LocalIdentity
approved these changes
Dec 8, 2022
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4962.
Description of the problem being solved:
Arcanist brand is a support and active gem. It support gems and gives them the brand skill flag.
We use this to tell if a skill is a brand for calculations.
This means a skill can have the brand flag and not be a brand.
This changes it so we pick brands by name instead.
Steps taken to verify a working solution:
Link to a build that showcases this PR:
https://pobb.in/deAifYYBO5VR
Before screenshot:
After screenshot: