Fix Skill Costs#5009
Merged
LocalIdentity merged 1 commit intoPathOfBuildingCommunity:devfrom Dec 8, 2022
Merged
Conversation
LocalIdentity
approved these changes
Dec 8, 2022
This was referenced Dec 11, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5007.
Description of the problem being solved:
Mana cost was applying to mana and divine blessing wasn't handled correctly with blood magic or life as extra cost of mana
There are some really weird rounding issues. That I don't know how to fix so these calculations are often off by one when gem mana multipliers are in play.
Lifetap / Petrified Blood Implemenation could be converted to be more generic as if in the future we saw mana to es conversion or similar.
Steps taken to verify a working solution:
https://pastebin.com/tft9bXja
Petrified Blood
Blood Magic
