Skip to content

FIX crash when generating fall back weights caused by missing source#5055

Merged
LocalIdentity merged 1 commit intoPathOfBuildingCommunity:devfrom
Paliak:fixCrashNoModSource
Sep 14, 2022
Merged

FIX crash when generating fall back weights caused by missing source#5055
LocalIdentity merged 1 commit intoPathOfBuildingCommunity:devfrom
Paliak:fixCrashNoModSource

Conversation

@Paliak
Copy link
Contributor

@Paliak Paliak commented Sep 8, 2022

Fixes ##5053 .

Description of the problem being solved:

Nodes coming from timeless jewels do not have their source property set. When running sum on a modDB with such a mod and the source property set in the cfg causes a match call to be called on nil which causes the crash.

@QuickStick123 QuickStick123 added bug Something isn't working crash Causes PoB to crash and is High Priority labels Sep 10, 2022
Copy link
Contributor

@QuickStick123 QuickStick123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working crash Causes PoB to crash and is High Priority

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants