Skip to content

Fix missing elemental resist calculation#5134

Merged
LocalIdentity merged 1 commit intoPathOfBuildingCommunity:devfrom
PJacek:missing-resist
Oct 20, 2022
Merged

Fix missing elemental resist calculation#5134
LocalIdentity merged 1 commit intoPathOfBuildingCommunity:devfrom
PJacek:missing-resist

Conversation

@PJacek
Copy link
Contributor

@PJacek PJacek commented Oct 13, 2022

Description of the problem being solved:

Missing resistance calculations were using totem's maximum resistance instead of player's

Steps taken to verify a working solution:

  • Equip Replica Nebulis
  • Get fire resist close to max
  • Observe amount of increased fire damage

Link to a build that showcases this PR:

https://pobb.in/go2n11_TF6bs

Before screenshot:

image

After screenshot:

image

@PJacek PJacek added the bug: calculation Numerical differences label Oct 13, 2022
@LocalIdentity LocalIdentity merged commit 66e033e into PathOfBuildingCommunity:dev Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug: calculation Numerical differences

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants