Skip to content

Fix rare templates not getting implicit mod tags#5149

Merged
LocalIdentity merged 1 commit intoPathOfBuildingCommunity:devfrom
Wires77:rare_template_implicits
Dec 4, 2022
Merged

Fix rare templates not getting implicit mod tags#5149
LocalIdentity merged 1 commit intoPathOfBuildingCommunity:devfrom
Wires77:rare_template_implicits

Conversation

@Wires77
Copy link
Member

@Wires77 Wires77 commented Oct 20, 2022

Description of the problem being solved:

When editing an item from the rare template list, implicit mods were not affected by catalysts

Steps taken to verify a working solution:

  • Used the crystal belt rare template
  • Added Tempering Catalyst
  • Noticed the energy shield implicit changed properly after my fix

Link to a build that showcases this PR:

N/A, import from the rare template list instead

Before screenshot:

image
image

After screenshot:

image
image

@Wires77 Wires77 added the bug: calculation Numerical differences label Oct 20, 2022
@LocalIdentity LocalIdentity merged commit 681e5fd into PathOfBuildingCommunity:dev Dec 4, 2022
@Wires77 Wires77 deleted the rare_template_implicits branch February 8, 2023 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug: calculation Numerical differences

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants