Fix Scorching Ray exposure not applying when using calculate maximum sustainable stages option#5164
Merged
Wires77 merged 1 commit intoPathOfBuildingCommunity:devfrom Dec 9, 2022
Conversation
Member
|
Is there a reason we didn't reuse the buff calculation logic from ~line 1818 for this? Seems like we could've popped that into a function and recalculated for those certain skills. Edit: Discussion in Discord answered this: |
Paliak
added a commit
to Paliak/PathOfBuilding
that referenced
this pull request
Jul 13, 2024
Essentially an improved version of PathOfBuildingCommunity#5164 that utilizes skill cache functionality.
LocalIdentity
pushed a commit
that referenced
this pull request
Jul 21, 2024
…ds (#7678) * FIX: maximum sustainable stacks calculations ignoring certain buffs/mods Essentially an improved version of #5164 that utilizes skill cache functionality. * FIX: spelling * TEST: add tests for schorching ray and blight interactions * FIX: formatting * DOCS: add fancy annotation for new function * FIX: calculate the correct skill * FIX: annotation * FIX: use activation frequency for penance brand
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5162 .
Description of the problem being solved:
Scorching ray applies exposure when at maximum stages. 222a1c5 moved the logic that calculates maximum sustainable stages for a few skills to after buffs/debuffs are applied to take arcane surge cast speed buff into consideration causing mods that use stage count as thresholds to not be added when they should.
Before screenshot:
After screenshot: