Skip to content

Fix maximum shock double counting.#5173

Merged
Wires77 merged 2 commits intoPathOfBuildingCommunity:devfrom
QuickStick123:fix-max-shock-double-count
Nov 23, 2022
Merged

Fix maximum shock double counting.#5173
Wires77 merged 2 commits intoPathOfBuildingCommunity:devfrom
QuickStick123:fix-max-shock-double-count

Conversation

@QuickStick123
Copy link
Contributor

Description of the problem being solved:

Maximum shock double counting as raised by @Diyu on discord.
Introduced in #5003

Steps taken to verify a working solution:

  • Maximum shock seems to work with shock nova, tree, voltatic rift and shocked grounds.
  • Paliak seemed to suggest there might be an edge case this doesn't work with.

Link to a build that showcases this PR:

https://pobb.in/eyUrFjTSZLfi

Before screenshot:

image
image
image

After screenshot:

image
image
image

@QuickStick123 QuickStick123 added the bug: calculation Numerical differences label Nov 22, 2022
@Wires77 Wires77 merged commit cf1632f into PathOfBuildingCommunity:dev Nov 23, 2022
@QuickStick123 QuickStick123 deleted the fix-max-shock-double-count branch November 23, 2022 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug: calculation Numerical differences

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants