Skip to content

Fix conversion and charges being negative#5186

Merged
LocalIdentity merged 1 commit intoPathOfBuildingCommunity:devfrom
QuickStick123:fix-negative-behaviours
Dec 4, 2022
Merged

Fix conversion and charges being negative#5186
LocalIdentity merged 1 commit intoPathOfBuildingCommunity:devfrom
QuickStick123:fix-negative-behaviours

Conversation

@QuickStick123
Copy link
Contributor

Fixes #5097

Description of the problem being solved:

Negative charges and conversion is being fixed in the next update.

The self curse bug wasn't a problem in PoB

Fixed a bug where having negative values of damage conversion would grant extra damage of the initial damage type.

Fixed a bug that allowed the total value of minimum power, frenzy or endurance charges to go negative, which could cause skills to act as if players had more charges than they actually did.

Steps taken to verify a working solution:

  • Negative charges result in zero discharge damage
  • Negative Conversion doesn't increase damage

Link to a build that showcases this PR:

https://pobb.in/tpMBPfRjjSiK

Before screenshot:

image
image

After screenshot:

image
image

@QuickStick123 QuickStick123 changed the title Fix conversion and charges being negative. Fix conversion and charges being negative Dec 2, 2022
@QuickStick123 QuickStick123 added the bug: calculation Numerical differences label Dec 2, 2022
@LocalIdentity LocalIdentity merged commit a93020f into PathOfBuildingCommunity:dev Dec 4, 2022
@QuickStick123 QuickStick123 deleted the fix-negative-behaviours branch December 14, 2022 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug: calculation Numerical differences

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Certain negative mods behave incorrectly in both PoE and PoB.

2 participants