Skip to content

Fix: crash on crafting certain quirky items#5204

Merged
LocalIdentity merged 1 commit intoPathOfBuildingCommunity:devfrom
Nostrademous:FixItemBaseError
Dec 6, 2022
Merged

Fix: crash on crafting certain quirky items#5204
LocalIdentity merged 1 commit intoPathOfBuildingCommunity:devfrom
Nostrademous:FixItemBaseError

Conversation

@Nostrademous
Copy link
Contributor

Fixes #5109

Description of the problem being solved:

The short-cut to strip a repeat of the base name of an item appear as a modifier when copy/pasting from trade website was incorrectly implemented to short-circuit entry into the subsequent if block by setting specName to a value.

This caused certain parameters of quirky items like a Fishing Rod, Timeless Jewel or Ring of subtype Ring (basically any item with a subType equal to the main base item Type) to not be properly initalized.

Steps taken to verify a working solution:

Link to a build that showcases this PR:

Just make any build and Item -> Craft item... OR Create Custom...

Before screenshot:

Would throw error when mousing over Base of Fishing Rod
Before

After screenshot:

After

@Nostrademous Nostrademous added the crash Causes PoB to crash and is High Priority label Dec 6, 2022
@LocalIdentity LocalIdentity merged commit a7a4d2c into PathOfBuildingCommunity:dev Dec 6, 2022
@Nostrademous Nostrademous deleted the FixItemBaseError branch December 6, 2022 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

crash Causes PoB to crash and is High Priority

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error when trying to add a timeless jewel base / ring / fishing rod

2 participants