Fix: crash on crafting certain quirky items#5204
Merged
LocalIdentity merged 1 commit intoPathOfBuildingCommunity:devfrom Dec 6, 2022
Merged
Fix: crash on crafting certain quirky items#5204LocalIdentity merged 1 commit intoPathOfBuildingCommunity:devfrom
LocalIdentity merged 1 commit intoPathOfBuildingCommunity:devfrom
Conversation
LocalIdentity
approved these changes
Dec 6, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5109
Description of the problem being solved:
The short-cut to strip a repeat of the base name of an item appear as a modifier when copy/pasting from trade website was incorrectly implemented to short-circuit entry into the subsequent
ifblock by settingspecNameto a value.This caused certain parameters of quirky items like a Fishing Rod, Timeless Jewel or Ring of subtype Ring (basically any item with a subType equal to the main base item Type) to not be properly initalized.
Steps taken to verify a working solution:
Link to a build that showcases this PR:
Just make any build and Item ->
Craft item...ORCreate Custom...Before screenshot:
Would throw error when mousing over

Baseof Fishing RodAfter screenshot: