Change watcher's eye dodge mods to suppress mods#5562
Change watcher's eye dodge mods to suppress mods#5562Wires77 merged 1 commit intoPathOfBuildingCommunity:devfrom
Conversation
|
This is actually generated automatically now. https://github.com/PathOfBuildingCommunity/PathOfBuilding/blob/dev/src/Data/Uniques/Special/Generated.lua#L565 I'm not actually sure how you got the dodge mods to appear since the generated version of the jewel should take precedence...were you on a really old version by chance? Regardless, the proper fix would be to simply remove Watcher's Eye from jewel.lua. |
|
Oh i see. And well im on latst dev branch so not sure, they are just there. |
This fixes these mods: - Haste one is legacy but in standard its suppress spell damageA - Grace is now suppress spell damage not dodge Signed-off-by: Tomas Slusny <slusnucky@gmail.com>
|
Alright removed watchers eye from the file instead and it looks like that works too |
|
What OS are you on? I assume it behaves correctly with other generated uniques and if you remove watchers eye from jewel.lua? |
|
linux (arch), with pobfrontend. And yea after i removed watchers eye from jewel.lua it behaves correctly, i am not sure about other generated uniques. I checked on windows without pobfrontend and there its behaving fine. I guess its just some scuffed load order on pobfrontend then. Still removing it from the file probs do not hurts anyone and at least fixes it on linux i guess? |
|
Yeah, this looks good to me, I may check on the underlying issue at some point, but in reality this shouldn't really happen anyway |
…Community#5562) This fixes these mods: - Haste one is legacy but in standard its suppress spell damageA - Grace is now suppress spell damage not dodge Signed-off-by: Tomas Slusny <slusnucky@gmail.com> Signed-off-by: Tomas Slusny <slusnucky@gmail.com>
2 participants
Signed-off-by: Tomas Slusny slusnucky@gmail.com
Before screenshot:
After screenshot: