Fix skillType tags for maximum Ballista Totem mods#5577
Merged
LocalIdentity merged 1 commit intoPathOfBuildingCommunity:devfrom Apr 1, 2023
Merged
Conversation
Contributor
Contributor
Author
|
I saw that as well, I was confused about cursed ground adding that tag because it doesn't really have anything to do with totem skills. At the moment all ballistas are bow attacks, and those nodes are processed that way by the " |
Contributor
Contributor
Author
|
I'm not sure what tag the cursed ground tag was supposed to be (something to do with how there's maximum one, or that it starts persisting in an area like an orb?) so I'm not sure what I should change the cursed ground skilltype to. I think the TotemsAreBallistae is appropriate to keep for the ballista skills. |
Contributor
|
Sorry got confused with how these are exported. Should be fine. |
LocalIdentity
approved these changes
Apr 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Fixes #5488 .
Description of the problem being solved:
Volcanic Fissure supported by Earthbreaker incorrectly gets +1 totem limit from "Attack Skills have +1 to maximum number of Summoned Ballista Totems" mods such as from Panopticon and Watchtowers.
Steps taken to verify a working solution:
Link to a build that showcases this PR:
https://pastebin.com/yzzh77Gp
Before screenshot:
After screenshot: