Fix socket group linking not working on weapon swap and generalize socket group linking code.#5600
Merged
LocalIdentity merged 1 commit intoPathOfBuildingCommunity:devfrom Feb 18, 2023
Conversation
Generalize implementation of group linking
LocalIdentity
approved these changes
Feb 18, 2023
Dullson
pushed a commit
to Dullson/PathOfBuilding
that referenced
this pull request
Dec 6, 2023
…cket group linking code (PathOfBuildingCommunity#5600) Generalize implementation of group linking
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5584 .
Description of the problem being solved:
The old code used hard coded slot names which did not take into account the "swap" suffix that weapon slots have.
Steps taken to verify a working solution:
Link to a build that showcases this PR:
https://pobb.in/hAVkORH1aWmN