Skip to content

Fix group disable not disabling support gems and two part skills not applying support part to linked groups #5719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LocalIdentity merged 1 commit into from
Feb 28, 2023
Merged

Fix group disable not disabling support gems and two part skills not applying support part to linked groups #5719

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Modules/CalcSetup.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -944,10 +944,10 @@ function calcs.initEnv(build, mode, override, specEnv)
else
for _, socketGroup in pairs(build.skillsTab.socketGroupList) do
-- Look for other groups that are socketed in the item
if socketGroup.slot == grantedSkill.slotName and not socketGroup.source then
if socketGroup.slot == grantedSkill.slotName and not socketGroup.source and socketGroup.enabled then
-- Add all support gems to the skill's group
for _, gemInstance in ipairs(socketGroup.gemList) do
if gemInstance.gemData and gemInstance.gemData.grantedEffect.support then
if gemInstance.gemData and (gemInstance.gemData.grantedEffect.support or (gemInstance.gemData.secondaryGrantedEffect and gemInstance.gemData.secondaryGrantedEffect.support)) then
t_insert(group.gemList, gemInstance)
end
end
Expand Down