Fix group disable not disabling support gems and two part skills not applying support part to linked groups#5719
Merged
LocalIdentity merged 1 commit intoPathOfBuildingCommunity:devfrom Feb 28, 2023
Conversation
LocalIdentity
approved these changes
Feb 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5482 , #1065 .
Description of the problem being solved:
#5482 Currently there is no check whether a group is enabled or not when groups are linked together based on the item they're socketed in. This pr adds it.
#1065 Two parts skills (Active and Support in one) such as Arcanist brand currently do not have their support parts applied to linked groups (in the same item). This pr adds a check for the case where
secondaryGrantedEffectis a support.Before screenshot:
After screenshot:
Before screenshot:
After screenshot: