Skip to content

Follow Through not applying to poison#5722

Merged
LocalIdentity merged 1 commit intoPathOfBuildingCommunity:devfrom
Paliak:followThroughFix
Feb 28, 2023
Merged

Follow Through not applying to poison#5722
LocalIdentity merged 1 commit intoPathOfBuildingCommunity:devfrom
Paliak:followThroughFix

Conversation

@Paliak
Copy link
Contributor

@Paliak Paliak commented Feb 27, 2023

Fixes #5708 .

Description of the problem being solved:

Piece wise parsing of
Projectiles deal 15% increased Damage with Hits and Ailments for each remaining Chain
adds the ModFlag.Projectile requirement to the mod which prevents it from being applied to ailments due to mod matching logic requiring all ModFlags to match.

This pr add explicit parsing for the mod that requires SkillType.Projectile instead of the ModFlag.

@QuickStick123
Copy link
Contributor

This band is causing it to delete all the projectile tags I wonder if this could just be removed or handled better.
image
image

@QuickStick123 QuickStick123 added the bug: calculation Numerical differences label Feb 27, 2023
@Paliak
Copy link
Contributor Author

Paliak commented Feb 27, 2023

@QuickStick123 I experimented with that for a while but couldn't figure out anything that worked correctly. Removing that band call seems to cause a whole bunch of mods to apply that shouldn't. Same thing with just adding ModFlag.Projectile to the mod.

I also tried implementing it kind of how the ModFlag.MeleeHit flag is done but due the requirement that all ModFlags match, it would either only apply to ailments or projectiles.

@QuickStick123
Copy link
Contributor

Also #2187

@LocalIdentity LocalIdentity merged commit b8967ab into PathOfBuildingCommunity:dev Feb 28, 2023
Dullson pushed a commit to Dullson/PathOfBuilding that referenced this pull request Dec 6, 2023
@Paliak Paliak deleted the followThroughFix branch January 20, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug: calculation Numerical differences

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Follow-Through not working with poison

3 participants