Follow Through not applying to poison#5722
Merged
LocalIdentity merged 1 commit intoPathOfBuildingCommunity:devfrom Feb 28, 2023
Merged
Follow Through not applying to poison#5722LocalIdentity merged 1 commit intoPathOfBuildingCommunity:devfrom
LocalIdentity merged 1 commit intoPathOfBuildingCommunity:devfrom
Conversation
Contributor
Contributor
Author
|
@QuickStick123 I experimented with that for a while but couldn't figure out anything that worked correctly. Removing that I also tried implementing it kind of how the |
Contributor
|
Also #2187 |
LocalIdentity
approved these changes
Feb 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Fixes #5708 .
Description of the problem being solved:
Piece wise parsing of
Projectiles deal 15% increased Damage with Hits and Ailments for each remaining Chainadds the
ModFlag.Projectilerequirement to the mod which prevents it from being applied to ailments due to mod matching logic requiring all ModFlags to match.This pr add explicit parsing for the mod that requires
SkillType.Projectileinstead of the ModFlag.