add fourth unique modifier to Vorana's March#5776
Merged
LocalIdentity merged 7 commits intoPathOfBuildingCommunity:devfrom Mar 31, 2023
Merged
add fourth unique modifier to Vorana's March#5776LocalIdentity merged 7 commits intoPathOfBuildingCommunity:devfrom
LocalIdentity merged 7 commits intoPathOfBuildingCommunity:devfrom
Conversation
Contributor
|
There is also #5444 which is similar if you wanted to tackle another issue. |
Contributor
Author
|
Added a change to address #5444, and added "None" to the variant/mod list for both items. I feel like there's a better way to add it than just putting it in the array manually as I have, and there also doesn't seem to be a way to distinguish between patch versions for these generated items, since the variant system is being used for these mods themselves. |
QuickStick123
added
bug: accuracy
Member
|
#5680 messes with variants a bit and might help with legacy variants for generated items, but its still WIP |
LocalIdentity
approved these changes
Mar 31, 2023
Dullson
pushed a commit
to Dullson/PathOfBuilding
that referenced
this pull request
Dec 6, 2023
…#5776) * added fourth unique modifier to Vorana's March * explicitly define selected variants * add unselected third mod to Balance of Terror * add 'None' mod option for Balance of Terror * add None option for legacy Vorana's March items * Fix blank Variant index and add blank for Watchers Eye --------- Co-authored-by: LocalIdentity <localidentity2@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5617 & fixes #5444.
I also added explicit definitions for all 4 unique mods, though I don't really know which ones people are likely to choose.