Skip to content

Bugfix: Strength adding to minions at half value#5804

Merged
LocalIdentity merged 1 commit intoPathOfBuildingCommunity:devfrom
synotim:fix/strength-to-minions
Mar 31, 2023
Merged

Bugfix: Strength adding to minions at half value#5804
LocalIdentity merged 1 commit intoPathOfBuildingCommunity:devfrom
synotim:fix/strength-to-minions

Conversation

@synotim
Copy link
Contributor

@synotim synotim commented Mar 31, 2023

Fixes a bug where strength adding to minions was only applying at half value.

Description of the problem being solved:

"Your strength is added to your minions" was only applying at half value due to a miss-flag.

Steps taken to verify a working solution:

  • Added raise zombie gem
  • Custom modifier +1000 strength
  • Custom modifier your strength is added to your minions
  • In calcs toggle on "Show minion stats"
  • Zombies are now getting the full 1020 strength that the player has

Link to a build that showcases this PR:

https://pobb.in/mUR8tBJ1boJd

Before screenshot:

fix-strength-to-minions_before

After screenshot:

fix-strength-to-minions_after

@QuickStick123 QuickStick123 added the bug: calculation Numerical differences label Mar 31, 2023
@LocalIdentity LocalIdentity merged commit e4cac2c into PathOfBuildingCommunity:dev Mar 31, 2023
Dullson pushed a commit to Dullson/PathOfBuilding that referenced this pull request Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug: calculation Numerical differences

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants