Fix flask conditions for using Life and Mana flasks#5854
Merged
LocalIdentity merged 1 commit intoPathOfBuildingCommunity:devfrom Apr 2, 2023
Merged
Fix flask conditions for using Life and Mana flasks#5854LocalIdentity merged 1 commit intoPathOfBuildingCommunity:devfrom
LocalIdentity merged 1 commit intoPathOfBuildingCommunity:devfrom
Conversation
Signed-off-by: Tomas Slusny <slusnucky@gmail.com>
LocalIdentity
approved these changes
Apr 2, 2023
Dullson
pushed a commit
to Dullson/PathOfBuilding
that referenced
this pull request
Dec 6, 2023
…mmunity#5854) Signed-off-by: Tomas Slusny <slusnucky@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
The current parsing for life/mana flasks was wrong as it was adding conditions like UsingDivineLifeFlask insead of simply adding UsingLifeFlask etc.
Steps taken to verify a working solution:
Link to a build that showcases this PR:
https://pobb.in/1GG8yuGg_pUw
Before screenshot:
After screenshot: