Skip to content

Fix sorting getting stuck#681

Merged
LocalIdentity merged 1 commit into
PathOfBuildingCommunity:devfrom
PJacek:sorting-stuck
Apr 8, 2020
Merged

Fix sorting getting stuck#681
LocalIdentity merged 1 commit into
PathOfBuildingCommunity:devfrom
PJacek:sorting-stuck

Conversation

@PJacek
Copy link
Copy Markdown
Contributor

@PJacek PJacek commented Mar 26, 2020

When running jewel functions they get called for each node and nil. Sockets coming from cluster jewels are not in range of any nodes (which is correct) and the unique effect from Might in All Forms didn't have checks for that case. This would also cause a crash when trying to use the jewel.

Fixes #612

@LocalIdentity LocalIdentity added the bug Something isn't working label Mar 26, 2020
@LocalIdentity LocalIdentity linked an issue Mar 26, 2020 that may be closed by this pull request
@LocalIdentity LocalIdentity merged commit 670a74f into PathOfBuildingCommunity:dev Apr 8, 2020
@LocalIdentity LocalIdentity linked an issue Apr 13, 2020 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

error with socketed jewel Sorting Unique Items gets stuck at 26%

3 participants