Fix PoB Trader not prioritising local weapon mods#9625
Merged
LocalIdentity merged 1 commit intodevfrom Mar 14, 2026
Merged
Conversation
The PR #9394 made a change to sort the stat list by weight instead of the meanStatDiff like we had it before. This was prioritising high value mods that contributed a low total sum to the item and was forcing the search to ignore low weight but high value mods like local weapon damage rolls
LocalIdentity
added
bug: behaviour
github-actions bot
pushed a commit
to PathOfBuildingCommunity/PathOfBuilding-PoE2
that referenced
this pull request
Mar 14, 2026
LocalIdentity
added a commit
to PathOfBuildingCommunity/PathOfBuilding-PoE2
that referenced
this pull request
Mar 14, 2026
Co-authored-by: LocalIdentity <LocalIdentity@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
PR #9394 made a change to sort the stat list by individual mod weight instead of the meanStatDiff like we had it before. This was prioritising high weight mods that contributed a low total value to the item and was forcing the search to ignore low weight but high value mods like local weapon damage rolls
Link to a build that showcases this PR:
https://maxroll.gg/poe/pob/tv2uip0o
Before screenshot:
After screenshot: