Trader improvements by vaisest · Pull Request #9691 · PathOfBuildingCommunity/PathOfBuilding

vaisest · 2026-03-23T14:52:24Z

Description of the problem being solved:

This solves some annoying steps with the trader tool. Notably it allows for and defaults to filtering out whisper listings, as these are often not actually going to be sold at the listed price. For async trade it also adds a button to show the result page as apparently GGG considers using the direct whisper/travel API to be past the line of breaking TOS.

Steps taken to verify a working solution:

A decent amount of testing by finding upgrades for my own build, but no automated tests.

Sample build

https://pobb.in/B2SI3YzPgw93 (just my avatar of fire BV)

Before screenshot:

Body Armour:

Amulet:

After screenshot:

$Path{space}of{space}Building_2026-04-09_03-19-25$

Body Armour:

Amulet:

I have also implemented a copy setting that uses the currently equipped eldritch mods, enchants, and anoints. I think it makes sense to do this because it's quite rare for the results to have what you want, and they can be borderline required (as in the sample build gloves, which need fire conversion). It also helps show the true value of e.g. cord belts well.

Included are also fixes for #9678 which resulted in crashes and currency rates (and hence sorting) not working.

Note that this is based on the watcher's eye branch but I may have configured that incorrectly on Github.

- move find button to separate slot instead of using exisitng jewel sockets - use exisitng Watcher's Eye slot(if available) for usage in weight calculations with test item - added option to include rest of applicable mods from Watcher's Eye mod pool that have weight 0 in final query

…against an equipped eye

… useless

Moves the mods to their correct areas in ModParser Removes parsing for mods that we do not currently support calcs for

…he trade site

…int vs enchant for amulets and belts

pbLeagueRealName does not exist. The correct variable is pbLeague The scourge anchor has a typo in it

The trade site uses floats for the weights internally when sorting but only shows integers to the site and api Need to use +-1 so that it doesn't accidently miss an item e.g. before a weight of 100.3 would show as 100 in the api callback and then we'd search for 99.9 - 100.1 so the search would never show the item

Can now properly search for items when the user pastes a weighted sum search

The dropdown checked if the last changed dropdown was set to none instead of checking that both of the dropdowns were set to none. Setting an influence and setting it back to none would make the copy eldritch box become selectable when it shouldn't be

LocalIdentity

PR looks good now. I found a bunch of small issues with different functions and fixed them

Port of feature/bench-craft-eval onto current origin/dev. Adapted to upstream PathOfBuildingCommunity#9691 changes (removed enchantInSort reference, adjusted popup control anchoring for new layout). Fix pre-existing space indentation on upstream TradeQuery.lua line 629. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

…ries Port of feature/trade-query-required-mod-pins onto current origin/dev. Adapted to upstream PathOfBuildingCommunity#9691 changes (new popup layout, includeMirrored guarded for uniques, new control anchoring pattern). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Port of bugfix/trade-query-influence-none onto current origin/dev. Adapted to upstream PathOfBuildingCommunity#9691 changes: combined normalizeInfluenceSelections with copyEldritch interaction, Watcher's Eye guard, SetSel pattern, ^7 label prefixes. Updated isSpecificInfluenceSelection check for eldritch weight skip in ExecuteQuery. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Port of feature/resistance-swap onto current origin/dev. Adapted to upstream PathOfBuildingCommunity#9691 changes (removed enchantInSort, new popup layout, Watcher's Eye support, updated sort algorithm). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Port of feature/bench-craft-eval onto current origin/dev. Adapted to upstream PathOfBuildingCommunity#9691 changes (removed enchantInSort reference, adjusted popup control anchoring for new layout). Fix pre-existing space indentation on upstream TradeQuery.lua line 629. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

…ries Port of feature/trade-query-required-mod-pins onto current origin/dev. Adapted to upstream PathOfBuildingCommunity#9691 changes (new popup layout, includeMirrored guarded for uniques, new control anchoring pattern). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Port of bugfix/trade-query-influence-none onto current origin/dev. Adapted to upstream PathOfBuildingCommunity#9691 changes: combined normalizeInfluenceSelections with copyEldritch interaction, Watcher's Eye guard, SetSel pattern, ^7 label prefixes. Updated isSpecificInfluenceSelection check for eldritch weight skip in ExecuteQuery. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Port of feature/resistance-swap onto current origin/dev. Adapted to upstream PathOfBuildingCommunity#9691 changes (removed enchantInSort, new popup layout, Watcher's Eye support, updated sort algorithm). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Port of feature/trade-query-saved-options onto current origin/dev. Adds SetSavedOptions/save-back plumbing so that the options selected in the TradeQueryGenerator popup (include Mirrored/Corrupted/Scourge/ Talisman, Eldritch dropdown, influences, jewel type, max price / currency / max level) survive closing and re-opening the popup via TradeQuery:PriceItem. Adapted for upstream PathOfBuildingCommunity#9691 (Trader improvements popup remanie, with includeMirrored only created when the slot item is not unique and includeEldritch now being a 3-option dropdown). The original onlyImplicitWeights / requireUnique / includeSynthesis / includeAttrReqs fields are dropped as they no longer exist in the upstream generator. Also fixes a pre-existing space-indented line in TradeQuery.lua that was blocking the pre-commit tab-indentation check. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Display the current step (Search, Search 2..., etc.) and fetch progress (fetched/total...) directly on the "Find best" and "Price Item" buttons instead of only showing "Searching...". This gives feedback during the weighted recursion and during the block-by-block fetch. - TradeQueryRequests: plumb onSearchStart(step) and onFetchProgress(fetched, total) callbacks through SearchWithQuery, SearchWithQueryWeightAdjusted, FetchResults and SearchWithURL. - TradeQuery: each button now drives its own label; bestButton is kept disabled while its label is not "Find best", priceButton while its label is not "Price Item". - Add local m_min = math.min in TradeQueryRequests (also fixes an existing undefined reference used in the 429 retry backoff). - Drive-by: convert one pre-existing space-indented line in TradeQuery.lua to tabs so the pre-commit hook accepts the staged file. Ported onto current origin/dev (adapted for PathOfBuildingCommunity#9691 popup/SearchWithURL query-arg, PathOfBuildingCommunity#9767 lastQueries[row_idx], and the extracted UpdateDropdownList method). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Adds checkboxes on the Trade tab to reuse the currently equipped item's Eldritch implicits and amulet anoint when evaluating and displaying trade results. Also adds an "Include unusable" checkbox (UI only, filter logic not yet wired -- hence WIP). Routes result-item construction through a new TradeQueryClass:BuildResultItemWithOverrides helper used by GetResultEvaluation, UpdateDropdownList, the result tooltip and the Import Item button so overrides apply consistently. Port adapted to upstream changes: - PathOfBuildingCommunity#9691 removed enchantInSort/sort algorithm rework: dropped the conditional enchantModLines stripping; the new useCurrentAmuletEnchant checkbox replaces the only remaining meaningful use. - PathOfBuildingCommunity#9767 lastQueries[row_idx]: already in place, no conflict. - PathOfBuildingCommunity#9744 dropdown list refactor: plugged BuildResultItemWithOverrides into UpdateDropdownList instead of the old inline loop. Dropped the unused isEldritch helper from the original diff (it was defined but never called). includeUnusable checkbox state is plumbed but not yet consumed by any query/filter. Also fixes one pre-existing space-indented line in the same function that the pre-commit hook rejected. WIP -- upstream of feature/trade-query-current-item-overrides marked WIP (commit 2a7ad4a "WIP Keep implicits"). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

bornaivankovic and others added 13 commits December 25, 2023 23:22

Watcher's eye trade search

bdb6ce4

Merge remote-tracking branch 'upstream/dev' into dev

bd1173a

fix merge mistake

0dd17a2

remove debugger setup -.-

ef32c2c

Fix getting unweighted mods

c2ce9d3

Actually include corrupted mods

bbb2626

Merge remote-tracking branch 'upstream/dev' into dev

c555a45

fix checkboxcontrol for watchers eye

abfef51

show tooltips for watcher's eye search. either against all jewels or …

6ede9c8

…against an equipped eye

remove mirrored button from eye and megalomaniac search because it is…

61a5ee2

… useless

fix valid slot for watcher's eye

ebfe541

Merge branch 'PathOfBuildingCommunity:dev' into dev

c5dd88c

vaisest force-pushed the trader-improvements branch 3 times, most recently from 1149f4f to 688515e Compare April 6, 2026 17:37

vaisest marked this pull request as ready for review April 7, 2026 15:49

LocalIdentity and others added 13 commits April 15, 2026 20:58

Merge branch 'dev' into watchers

efe8227

Move mods to correct places

7b18c37

Moves the mods to their correct areas in ModParser Removes parsing for mods that we do not currently support calcs for

Fix crash when opening trader with empty jewel socket

3f8a540

Fix skill name parsing

780e186

add "include in person" setting

2777578

change in person selection to be a dropdown of the ones that are on t…

58d19e1

…he trade site

add button to find exact search result for trade tool

a6f2a52

trade query result filtering via trader name

74ee6e2

fix trader tool item slot anchor

8ae1078

improvements to timeless jewel tool: trade type and realm selections

cf16771

trader tool: option to use current implicits and enchants

22a00d0

as per comments: move implicit and enchant overrides to query options

380033b

trader tool: add option to omit "while" eldritch mods and clarify ano…

fcb261c

…int vs enchant for amulets and belts

LocalIdentity added the enhancement New feature, calculation, or mod label Apr 15, 2026

LocalIdentity added 14 commits April 15, 2026 22:37

Fix test

8889bdc

Fix league name and scourge ui anchor

41b1324

pbLeagueRealName does not exist. The correct variable is pbLeague The scourge anchor has a typo in it

Use last query for manually pasted strings

e90500d

Can now properly search for items when the user pastes a weighted sum search

Add any to trade search types

716fe21

Spelling mistakes

542a465

Wrong variable name for control

bd5c6f1

More filters incase missing search elements

c3e5070

Issue with newItem.base.weapon bypassed rest of checks

0492500

Fix Timeless jewel league selection resetting

2de61d9

Remove debug console prints

d4bb179

Fix weapon enchant only copying from weapon slot 1

756390d

Comments

3b777f2

LocalIdentity approved these changes Apr 16, 2026

View reviewed changes

LocalIdentity merged commit 12ea1a4 into PathOfBuildingCommunity:dev Apr 16, 2026
2 of 3 checks passed

LocalIdentity mentioned this pull request Apr 16, 2026

Timeless Jewel trade search should default to "instant buyout only" #9671

Closed

LocalIdentity mentioned this pull request Apr 16, 2026

fix(trade): Trade: open GGG trade with filters for selected item #9430

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Trader improvements#9691

Trader improvements#9691
LocalIdentity merged 49 commits intoPathOfBuildingCommunity:devfrom
vaisest:trader-improvements

vaisest commented Mar 23, 2026 •

edited by LocalIdentity

Loading

Uh oh!

LocalIdentity left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

vaisest commented Mar 23, 2026 • edited by LocalIdentity Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description of the problem being solved:

Steps taken to verify a working solution:

Sample build

Before screenshot:

After screenshot:

Uh oh!

LocalIdentity left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

vaisest commented Mar 23, 2026 •

edited by LocalIdentity

Loading