Fix stat comparison for radius jewels (timeless, Thread of Hope, etc.)#9746
Open
mcagnion wants to merge 3 commits into
Open
Fix stat comparison for radius jewels (timeless, Thread of Hope, etc.)#9746mcagnion wants to merge 3 commits into
mcagnion wants to merge 3 commits into
Conversation
mcagnion
force-pushed
the
feature/radius-jewel-stat-diff
branch
5 times, most recently
from
a090a49 to
f161d15
Compare
LocalIdentity
added
enhancement
LocalIdentity
requested changes
May 12, 2026
Contributor
LocalIdentity
left a comment
LocalIdentity
left a comment
There was a problem hiding this comment.
Currently removes all nodes from a radius jewel even if one of the nodes is in the radius of a different intuitive leap like jewel
Also the stat diff for radius jewels does not work when you are trying to see the impact of a different jewel in your build
mcagnion
added a commit
to mcagnion/PathOfBuilding
that referenced
this pull request
May 12, 2026
Rebuild comparison specs for radius jewel tooltip diffs so replacements and overlapping intuitive-leap effects are evaluated against the alternate tree state. Address PR PathOfBuildingCommunity#9746 review feedback from LocalIdentity and peer-review request 20260512T113521Z-codex-1043bc8f500b.
- Fix stat diff tooltip for removing equipped radius jewels: use jewelRadiusIndex instead of hardcoded radius, revert conquered nodes via removeNodes/addNodes override with hashOverrides support - Fix stat diff for removing Thread of Hope / Impossible Escape: remove nodes only reachable through the jewel and their transitive dependents - Add 9 tests covering radius jewel stat comparison Ported onto upstream PathOfBuildingCommunity#9744 sort-based compareSlot loop: override logic now lives inside getReplacedItemAndOutput() instead of the old inline for loop. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Rebuild comparison specs for radius jewel tooltip diffs so replacements and overlapping intuitive-leap effects are evaluated against the alternate tree state. Address PR PathOfBuildingCommunity#9746 review feedback from LocalIdentity and peer-review request 20260512T113521Z-codex-1043bc8f500b.
Strengthen the replacement tooltip test, preserve traceback when rebuilding comparison specs, and document the PassiveSpec field allowlist. Addresses full-branch review follow-ups from exploration 20260512T124426Z-codex-exploration-159337fbb665 and request 20260512T125918Z-codex-1dca732498d9.
mcagnion
force-pushed
the
feature/radius-jewel-stat-diff
branch
from
d948db9 to
f174020
Compare
Contributor
Author
|
Radius-jewel tooltip diffs now rebuild an alternate passive spec for removal/replacement instead of removing radius nodes manually. That preserves nodes still supported by another Intuitive Leap-like jewel, and it also makes replacement comparisons work when hovering a different jewel over an occupied socket. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
The stat diff tooltip when removing equipped radius jewels (Timeless, Thread of Hope, Impossible Escape) was missing or incomplete:
Steps taken to verify a working solution:
spec/System/TestRadiusJewelStatDiff_spec.lua):Screenshots:
Timeless jewel (Lethal Pride) — before:
Timeless jewel (Lethal Pride) — after:
Impossible Escape — before:
Impossible Escape — after:
Thread of Hope — before:
Thread of Hope — after:
🤖 Generated with Claude Code