Skip to content

Fix Catalyst scaling for Added Damage mods#9775

Open
Peechey wants to merge 1 commit intoPathOfBuildingCommunity:devfrom
Peechey:fix/catalyst-scaling-for-lightning-damage
Open

Fix Catalyst scaling for Added Damage mods#9775
Peechey wants to merge 1 commit intoPathOfBuildingCommunity:devfrom
Peechey:fix/catalyst-scaling-for-lightning-damage

Conversation

@Peechey
Copy link
Copy Markdown
Contributor

@Peechey Peechey commented Apr 17, 2026

Fixes #9738

Description of the problem being solved:

Damage mods (flat damage/flat damage to attacks) sometimes do not scale correctly with the respective catalyst when the first value of the mod is not a range, i.e. 1 vs (1-x). This PR will update the number of values to scale for these specific mods.

Steps taken to verify a working solution:

  • Validate flat damage to attacks craft
  • Validate hybrid damage craft
  • Validate uniques like Prismweave, Berek's Grip, and Maligaro's Restraint

More uniques to keep in mind: Circle of Regret, Replica Prismweave, Ryslatha's Coil

Link to a build that showcases this PR:

eNrtHGtv2zjyc_0rCAN7aHFxYsmPuLl0F46TNAGS1Gun7d2ngpFom1tK8kpUUm-R_34z1MOSbdmU5cV9uaJoZWpeHM6LNMfnv_1wBHlmfsA990PdOG7WCXMtz-bu9EP98-N1o1f_7dfa-ZDK2afJRcgFvvm19uZcPRNL0CB4oA77UB9bQKJOaGAx1x4sxx88l9XJM2cv954Nn2_vh59Gj3UiqT9l8kvCuvUNWM-pK2fMc-_pH57_0bMT7HScu7nxJ-raXCafHMrdsWd9Z_Kj74VzmE6dCPbMhHqyZtSnlmT-HQ71Q-lF8kg_ZHWY0ZvzoaAL5o8llSSAfz7U-6AYOmWX1IF_YQ5UhEwpqWt26idbcS5CP5ClEMdzxuwMrFkEOPTZ1WTCLMmf2cDncjCjrrXk0izCKwt7HwrJ54IzPyNVofg3a8QLQR89ScXlcJyd7OkOaE_uFvorl7MLAVrUpo0Yt1OXS1YKZejxwHNLzyCLUKz5UAhwMS3YEQuY_0wlzwtTTNtznrhbQj_31KUDL9DQPUIOmQ--L0shjJnlQbgoy6Mk5h2fMH3IUvOIEcpKs988rsa6cKUJ7yfQCOKbHuTYC4UmpFwGHLMQ6pL90IC6daUWrWdPquy1Szblylc3wxSy1Ts2zfeGedo8PS2O7cPZIuAWFff0B3dCB2LlI_3Olvy6W2xlOpMuBIQi1NZpEeo191l5rIEn7D2wZtQLCtF6xR7N3RvI4X3LCiE5L1KU9lbn0dAbZFPrDGFvXUvPIz-7vgqnmSTc3YowAj_BZP8kmCbGkkXsbcso3NzBasrcmN9Cbzp3jFmzj6DfEZVML7YuM3dnq1oRVkutCLhBrZ2OHkIJJSHiZiUZ21BKKunKZf50MZ5xJuxy0IlYAzrXCICo5Cy2lrLz7ErZSxa1pEq-Ut_WSxNlZXqmQTYkG93t6orA9cySQZEICDbTLYeHvvcHFtyiHFrfd7zQ11zwCFhrAkk6ifYXI2aHll76SvcNFwL2SbrTSLFATiFKofalpNb3S8-eaitNMSmFkZdvHM7nEEHQGnQJYKaEWppnqpNGVwP6E5iylkdjUtVnsITWZpCWCfpcVlD054KpvsRkluDaLNIFvYdg4UAKUHtj2K7vjurXsH3S2gspQM092dB7AclneGARlIOGkmhZBhWK4jP3r4U2_Ry4FoMr14byClxBm8cqxiY2j9yBQBoEl1RSEqhzl2suJPMvYa0RF-mTgFHfmt3B0DUV4gmiwYd6ndhxxf2F-py60lAnNCuDphpc4gMeMj4_UUdP-PToM_aFsxfyl-c5_1bs8Ok_GcawmUB-OHwXHQW14NXMe8HJXnIwNNCmxYL4HEgxGH_nQgQwJV9-ZE5wsQAjid8r1Ds2hVoVX32oT6gIGIo-oaFA8N9DKrhcRCJkKVxjdl3ZgytBIF5FcI-LOQrSv7urExoFNJRkzGSsnoRHPBPX8510TxEdYSUIhNuJk5yfRPPBx1sHWRH2A_8bUh_ljGagIG8lCBuzxueEcxiwaFP4ldG556rheOLFqlTyIJVYFvz8ZgRLKxdnZNQfXdUeYOUQoDZgfigYdckIwlFt4NOJZPYZQTK1oc8m_McZ-QnmOGVnzePTduu1b9vMTgNYlAbNFBRPA_MfxuFE58MALFksAnlGHkP_CURyZToWr-sZMZs1pf8R-_OM9Jo10KngFpfBGTFqPyWdBmeQfiCVW-zIgRrzNZW88_q21zCa734h3LV8RgNmEydaPYLVaA2mFRCDSI8YPZJOj0Tzw-EonQYxG_A-DI5UfLMVxFHoPjOoUexvjmcfxWMp0JEFaeVIJFRff1qRnhP5jFfF_q3RbBjmO-T21mg3jO47gvkoFuLv5Kwm_tY0Gmb73drs0XjOIQOMECO2KKLQwdOSU8kVCHMnRCuFMDa-b6--Pz9Bg82btomRUUUsJJgz888Pt79_vqpdgGd8_we4TvCvgHz0-bz2-OI1xhJsLjL5O0anITsjl57DXXWed0QeQHuQNbWNMo6aZwQsn5jH3eOVodZxLzs0CH0fSY1hmSxYDJK-aWXs2yyy7zjEZ437n28NE-3lF1xHZTOws88s5CjFKjLg15-xIsEksl6DJtnJuc1uk1zSMo9aOWpmp9FqlqR2RJXnFQiYMV-j0Wm-28d3IwZHFg0ggxYKn-HUaTZOC1ipOjhQ6s9zTQJTftlazUa7qTw-iUZ4gLCGspy68QvxJgk_tWEEJdJAoRE6hc1jIMl4hiWBTWBz6XAWFJLDGVYgCFlRZZ0lwWJy0T6XRBvdlO617_3F3J1yGkdmIWGM3kX0_ubAVQTR3gnR2QnR3QlxuhOitxPi_U4Io7kOsikSb46-9xAjp9T3kgAMcUj6sFQQRmfwH7lgQu6R-tvtTaFxaY5ZD3vfMPMOlrPEXTFno_uD0-6KNEazmY1yyn_IJdT1mGAI_F14YU2NBvhILAqFHqGQK6B2irMCFuxIE0G7OXIxv5cZ5P3EN-OZBLhdezU6WfBkK0fUXm4F7X_kI3t5wCbDa-8sAYY-D5wXRp9ZbRQGkltkTIPZAZO78X6P7N7ZZMLz-HQpTaTZTGxidZZd14_Ce6KCJEdSldPo21ajHVWfp43eO4KHLWWTaCa3rJNXVFWm7qjithqD9eScFM2xj7bMqiw2qMhstCIGncZprjw_jIo6jVh-rOfaVRlsUtFyi2G2G2avKovCYqzVME4rVGPbtJRG4Vb7IByKyrxus9Ht6XDIFuXZmiWXiLpg_ao-p0KQq0SmDaX5JmqtVVqqKNcgVjT5Vi6hLCkkqYXLWTxJEp_J2KGPOqDuglwLGnwn0VGhtqFgDVeW6f8ruL-nglsF2a1VY7dajd16Ndo7k_ryBG3L2VdEeiw8SVx10y2CAL8dv9A56T8tggDsKrqRRmAlOFAePn0e3eGJJH64tdMj2M2EVmi0D0DDLE_D3DihzgGE2Uspm4QpMyus96tMBiqeZxZUoXDDhMNklTlEwc841Fp2KwvfKi28ue_al1lqz16Q6IvVKr60yWLMyhbTPtTq7UWowvpt0Wr3AKKUmc5HPEku5QeR8bUrr145hXlyjYBRWQTzABG4c5h1N6pqo3MAwzlYOKw8m8rG0a1sHN1DKaN1KEJm5SRziBqqfKxolcwUpRnsU0mVQOk7oWCytPL3WPb9YklpUy_rXCXg8du4QuUaRQhmWQ4HyradqmGmahF0sPrdqBwbOvuGqYoqaB0gcZlV19E81Dq0DkWoU7qIq54eqhd1RkVjOMQGvVVRBuNQS3iIbcUhyrrqm1PjMOHWPAyZHQscHUWNmYwu2fnUZmN1le0rwzPgILrTpa5q4dOACiuIDq7ceQjsQ-eJ-eroKpIkwEPMb9FwzCGCDKSvujyvrq-vBo-3X64SDIcH1rencDLBBskYZczUFWN1KhZfMsNvluokCJ-C6N2HOt7FUy8vmaRcQOK1PCHoPGB29p5ZntoNT_sks7QUncw7DUpfQUs-x_ogS-jqB_MlTHT5VoOU6jdcEyeSBS-w491HLUJxV2eWVHS4PKCBjK7Ya1DBdsw8ERzRm8qtM6diRbnJmM4EcOJ4MxFv-QUblCLx1uKcWXzCrRhGb9WT29k53aSNQBo0VK9nHj8e0kCOejjz2MmYjlZV1-iKVuMxHftiFl3kseMhDeS0RSNPIB323Bs0Fw1KV4L1ucAvQFZW9sFzlbGD3ywBNAjeQ-iIvpJZIfhJzpifvtGgBF7i86dQrrpzdlxHV6pdLKcmNaIzF9USlUWNRnT0mmsUykWj3Bu9oLZCIhrRQE0u6WeRozHNJYi3Zzn1x2M6Skg6eHLzTwZ1nESF2_6zx-31SLH2sipB1ddyALmwc6U6mdVWFi2K6jhhxV-SsT3RP0uOl1A2UEnvy-8mgi5XjQJ6XjUKj9y1ZOgzLQKjtXJktFqEFGCmHRa5ZJ0M7omfdmPsTSHqGdkbXbW06GBj_L-Mr8BtSADLV5q5ZDOtaw8qOig3qNT1jGJaYxm6yZ24iqTUFDdHpP3UFafejVoroBgFlbj_ej1exi-0o1MRIagLbnQL0EJKaZvXDaMCf1XDE9UIrjWgVyGGrarhnLp2Qu7Tprq_9DJ4MgCaqoXpEjtiq-rQZc5iA6FlN9NJskM8f_CgakLSOJp8UE1USbsRlPFJq845fiCOuo6-iAs33K26sCeEh06v18JOKnU1gvqL_vJnf3Av63JcyuRTs04ktmotf-vH7OV-KSgCijbRsCtWD29mUs6Ds5OTl5eX4zmVM2_CfnDBji3POZkDEgjcUJvbBhI_6cOfi2lf_VGEThJK59HGO4h36biOPodZxNttnKhSFGoCH1RjFAEAGTdjQNkjYD50PgeB09an8cx76dvP6OuPYLpBrpVq4LkTPo31Gn2Iu6kU03QkuWYiuRQMNwGqxytWxVBQi808YTM_3debZjvd2jNc_HwzcHIUsQk1xXPSX_ZR5nNDhfBewKUhbzp6FMaWp5rr8P7ZNoR2M8GYpy3USXvgNrxOgmZFioIlkj4Vj3zK_IEXulILWekn87NHW3BaOZz0tt0Q_G0bp-ZmtLjy3oJ5mseMO7nBf9U9JX1J8eLkDiGXi4a3rXevWa-dnxReF94Gv2aRK415JRSY6ZPeNqGm0c5rIdlVbFV4nlV0MLNNzyuiZdqet2B1jfe99znEeMe0bT6pwWJDrZZ_ZFBSX8ZfpmI-s9UKKycZMzHZutLvu-tz3L1oawuOy1Yi_AR8ysWniSoqQVisNkusg5-eCZYLdfkoF7nBiDneM7MvFhDfFyXsNPODAWX0hGi7ZW-t4aQODsk8SRxRaleffq2dn6z-QN9_ARPWnQ0=

Before screenshot:

image image image image

After screenshot:

image image image image

@Peechey Peechey added the bug: calculation Numerical differences label Apr 17, 2026
@Peechey Peechey changed the title Fix Turbulent Catalyst scaling for Added Damage mods Fix Catalyst scaling for Added Damage mods Apr 17, 2026
@Peechey
Copy link
Copy Markdown
Contributor Author

Peechey commented Apr 17, 2026

Looking over other mods to see if I should adjust the match for values other than "adds x to y z damage"

EDIT:
Crusader's Lightning Damage per Power Charge is "1 to x Lightning Damage per Power Charge" so I will adjust the match to by "x to y z damage" that's a range of "(1-2) to x" so nevermind

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug: calculation Numerical differences

Projects

None yet

Development

Successfully merging this pull request may close these issues.

catalyst not applied to both portions of a mod

1 participant