Fix Catalyst scaling for Added Damage mods#9775
Open
Peechey wants to merge 1 commit intoPathOfBuildingCommunity:devfrom
Open
Fix Catalyst scaling for Added Damage mods#9775Peechey wants to merge 1 commit intoPathOfBuildingCommunity:devfrom
Peechey wants to merge 1 commit intoPathOfBuildingCommunity:devfrom
Conversation
Contributor
Author
|
Looking over other mods to see if I should adjust the match for values other than "adds x to y z damage" EDIT: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9738
Description of the problem being solved:
Damage mods (flat damage/flat damage to attacks) sometimes do not scale correctly with the respective catalyst when the first value of the mod is not a range, i.e. 1 vs (1-x). This PR will update the number of values to scale for these specific mods.
Steps taken to verify a working solution:
More uniques to keep in mind: Circle of Regret, Replica Prismweave, Ryslatha's Coil
Link to a build that showcases this PR:
Before screenshot:
After screenshot: