Skip to content

Fix Pathmind Simulation - #425

Merged
slinlee merged 1 commit into
devfrom
dh/fix-pathmind-simulation
Oct 13, 2021
Merged

Fix Pathmind Simulation#425
slinlee merged 1 commit into
devfrom
dh/fix-pathmind-simulation

Conversation

@kepricon

Copy link
Copy Markdown
Contributor

I tested with Ed's model(added getRewardTerms() into Mdoe's Simulation.py)
model_py_simulation.zip

curl -i -XPOST -H "X-PM-API-TOKEN: 11202253-5709-4eb7-9102-f87122314464" -F 'file=@/home/kepricon/Downloads/python_examples.zip' -F 'projectId=500' -F 'env=examples.mouse.single_agent_mouse_env.MouseAndCheese' -F 'start=TRUE' http://localhost:8081/py/upload

Here are Training results
image

https://s3.console.aws.amazon.com/s3/buckets/dh-training-dynamic-files.pathmind.com?region=us-east-1&prefix=id3086/output/&showversions=false

@kepricon kepricon self-assigned this Oct 13, 2021
@kepricon
kepricon requested a review from ejunprung October 13, 2021 08:51
@slinlee

slinlee commented Oct 13, 2021

Copy link
Copy Markdown
Contributor

@ejunprung the single agent was working already, right? we need the multi agent to work now?

@ejunprung

Copy link
Copy Markdown
Contributor

@slinlee It's not related to single vs multi-agent. I was testing the gym environment versus Pathmind simulation environment. I just happened to have the multi-mouse example ready to go at the time so I was using that for testing. It should still work fine, I haven't see any issues around multi-agent so far.

@slinlee

slinlee commented Oct 13, 2021

Copy link
Copy Markdown
Contributor

@ejunprung so what works right now?

  • gym env - works?
  • pathmind simulations - works?

@ejunprung

Copy link
Copy Markdown
Contributor

Still figuring that out. Need another day or two to finish testing so I'll compile a list after that. But so far, gym works fine. Pathmind simulations is broken but I still need to test Dae's fix.

Multi-agent mechanically should work but it's missing features (e.g. skip) so it won't be usable in practice.

@slinlee

slinlee commented Oct 13, 2021

Copy link
Copy Markdown
Contributor

k. yeah nice, def keep a list of the small things that need to be added

@slinlee

slinlee commented Oct 13, 2021

Copy link
Copy Markdown
Contributor

run tests

@ejunprung

Copy link
Copy Markdown
Contributor

@slinlee I think we need to add this fix to test environment. I still can't get my local py-nativerl working correctly. Do I need to build a new NativeRL or is that automated now?

@slinlee
slinlee merged commit 2a2f23f into dev Oct 13, 2021
@slinlee
slinlee deleted the dh/fix-pathmind-simulation branch October 13, 2021 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants